Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: filter query caching #447

Closed
Tracked by #450
KnorpelSenf opened this issue Jun 26, 2023 · 0 comments · Fixed by #456
Closed
Tracked by #450

perf: filter query caching #447

KnorpelSenf opened this issue Jun 26, 2023 · 0 comments · Fixed by #456

Comments

@KnorpelSenf
Copy link
Member

Currently, the filter query logic performs most of its work upfront in order to generate an efficient predicate function which can test updates. However, this is based on the assumption that inline queries are only computed once during setup.

It turns out that some plugins like the menu plugin dynamically create composers upon request, so the filter queries are recreated every time. This is superfluous work, so we should just cache the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant