Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 106: Removing a Role throws an exception #113

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

ddelponte
Copy link
Collaborator

@ddelponte ddelponte commented Apr 15, 2019

  • fixed bug so roles may be deleted without exception
  • added an integration
  • added .java-version to .gitignore so that jenv config files are ignored

This is a fix for Issue #106

- fixed bug so roles may be deleted without exception
- added an integration
- added `.java-version` to `.gitignore` so that `jenv` config files are ignored
@ddelponte ddelponte requested a review from sdelamo April 15, 2019 18:37
@ddelponte
Copy link
Collaborator Author

ddelponte commented Apr 15, 2019

@sdelamo The new test I added is failing, but I'm not sure why it would. Are you able to provide any insight?

The test passes when run in isolation with the annotation @IgnoreRest, but fails when the entire Spec is run.

Everything works as expected when tested manually.

- fixed the new test that was passing when run in isolation with the annotation `@IgnoreRest` but failing when run along with other tests in the `Spec`
@ddelponte
Copy link
Collaborator Author

@sdelamo , FYI I "fixed" the test by modifying a new User, User 2. This allows the test to pass

@sdelamo sdelamo removed their request for review November 23, 2020 05:00
@puneetbehl puneetbehl changed the base branch from 3.3.x to 4.0.x September 6, 2022 19:20
@puneetbehl puneetbehl merged commit fc7d475 into 4.0.x Sep 7, 2022
@puneetbehl puneetbehl deleted the issue106 branch September 7, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants