-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisConfigurationUtil #50
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have some question about configureService method:
for each connection if port, host, etc that are not specified the code is using Redis defaults.
I would suggest to use the main values before cascading to default values, so plugin user doesn't have to replicate all data in each connections if the values are not the default one.
Let me write an example:
redis {
port = 9200
host = 'johnny'
timeout = 3000
password = ''
enabled = true
connections {
cache {
database = 1
}
}
}
with current code, for cache connection:
port=6379
database=1
host=localhost
timeout=2000
with the way i'm proposing:
port=9200
database=1
host='johnny'
timeout=3000
don't you think it's a more concise and intuitive way?
If you think it's a good suggestion I can update that bit of code and create a pull request to review.
T
The text was updated successfully, but these errors were encountered: