Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log calls don't check if the respective logging level is enabled #19

Closed
fabiangebert opened this issue Oct 23, 2013 · 0 comments
Closed

Comments

@fabiangebert
Copy link

Thanks for this great plug-in. I'd like to suggest a performance improvement: currently, there are tons of "log.debug" calls that obviously don't have an effect but will result in expensive computation (if you process a lot of data).
Why don't you prefix every line with

!log.debugEnabled ?: log.debug...

or more explicit

if(log.debugEnabled) log.debug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant