Improvements to GORM DirtyCheckingTransformer to properly handle both Boolean and boolean type properties #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Any chance this could be reviewed when you have a chance? This PR fixes this issue #1646 which prevents us from upgrade. |
|
@puneetbehl Thanks for accepting the pull request !! BTW, any indication of when it might be available via grails-core? The latest version is now 5.1.7 and does not include this fix yet. It would be great to have 7.3.0 of both grails-data-mapping and gorm-hibernate5 available from grails-core so we can continue with our upgrading tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change on DirtyCheckingTransformer so getters are synthesized for Boolean properties in the same way that they are for boolean properties.
Fixes #1646