fix: Push charts to GHCR requires login #2998
Conversation
|
|
5330292
to
453e290
Compare
Bruh, really? Thanks for finding this! I overlooked this. Of couse, we have the same code at kube-prometheus-stack, too. |
yaaaa 🥳 😄 |
|
@micahhausler |
|
Any updates here? I'm really interested in OCI Charts :) |
|
Same here, would love to be able to pull the charts through OCI directly so I can test the helm charts within kustomize when using flux/argocd :) |
|
@Xtigyro @zalegrala Can someone of you please take a look here? |
.github/workflows/release.yaml
Outdated
| if ! helm push "${pkg}" "oci:https://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts"; then | ||
| echo '::warning:: helm push failed!' | ||
| fi | ||
| helm push "${pkg}" "oci:https://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts" |
There was a problem hiding this comment.
Just to be in sync with the classic workflow
helm repo add grafana https://grafana.github.io/helm-chartsShall we change this also to oci:https://ghcr.io/${GITHUB_REPOSITORY_OWNER}/helm-charts
There was a problem hiding this comment.
I would say, the "world" is using "charts", including prometheus-community, fluxcd, velero.
There was a problem hiding this comment.
yes but helm-charts already exists for other Grafana-labs projects
https://github.com/grafana/grafana-operator/pkgs/container/helm-charts%2Fgrafana-operator
Signed-off-by: Marco Maurer <[email protected]>
6dc2d62
to
0d901a8
Compare
|
any update on this? 🙏 |
|
Great Success! 🚀 |
Resolves #2481
OCI chart push was introduced by @jkroepke here:
But it fails due to missing docker login to GHCR.
I am a Argo helm maintainer and we use almost the identical code:
https://github.com/argoproj/argo-helm/blob/fa85e824f014ef7bf19163d4ecf7e9b8eb01f6b9/.github/workflows/publish.yml#L67C15-L82
/cc: @zanhsieh as you merged @jkroepke PRs in the past