Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsSql DataSource: Add possibility to use authorization via workload identity #80369

Open
sbebrys opened this issue Jan 11, 2024 · 6 comments
Open
Labels
area/auth area/datasource datasource/MSSQL Microsoft SQL Server Data Source triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced type/feature-request

Comments

@sbebrys
Copy link

sbebrys commented Jan 11, 2024

Why is this needed:

MsSql data source for passwordless authentication has only possibility to use msi, which is limited to the tenant and identity used by grafana server and made solution less secured because access to set of sql servers cannot be controlled more precisely. Workload Identity could easily change that and open gradual access to specific clients (managed identities) within different tenants and also clouds.

What would you like to be added:

Add new auth type based on Workload Identity for MsSql data source, with possibility to choosing for each data source instance cloud, tenantId and clientId as similar requested and accepted change for Azure Monitor #76270.

To be consistent msi auth type should also get possibility to choosing clientId of used identity.

Who is this feature for?

Grafana data source administrator

@usmangt usmangt added area/auth datasource/MySQL area/datasource triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced labels Feb 1, 2024
@usmangt
Copy link
Contributor

usmangt commented Feb 1, 2024

Hi @sbebrys,

Thanks for opening this issue.

I will forward this to our Engineers so that they can have a look and might be able to tell more details about it.

@usmangt usmangt added type/feature-request datasource/MSSQL Microsoft SQL Server Data Source and removed datasource/MySQL labels Feb 1, 2024
@alyssabull alyssabull changed the title MsSql DataSource: Add possibility to use auhorization via workload identity MsSql DataSource: Add possibility to use authorization via workload identity Feb 27, 2024
@alyssabull
Copy link
Contributor

alyssabull commented Feb 27, 2024

Thanks for raising this issue. I have added it to our backlog and our team will discuss/update accordingly.

@Etshawy1
Copy link

Etshawy1 commented May 9, 2024

In case someone is self-hosting Grafana in AKS cluster. I could get it to work with some simple changes

main changes needed: Etshawy1@e802934
fix an error in the first commit: Etshawy1@4bddce2

the main requirement is to properly configure the workload identity and you double check that the env variables related to the workload identity are set
AZURE_TENANT_ID
AZURE_FEDERATED_TOKEN_FILE
AZURE_AUTHORITY_HOST
AZURE_CLIENT_ID

@darguelles-am
Copy link

This feature could also be added to PostgresSQL servers in Azure.

@DilongWu
Copy link

DilongWu commented Jul 4, 2024

Hi @usmangt , It's a very important feature to us. When will this pr be merged? Thanks!

@usmangt
Copy link
Contributor

usmangt commented Jul 8, 2024

Hi @DilongWu ,

As @alyssabull updated in the comment, it needs to be discussed first with-in the teams if this can be done easily or needs additional resources (that can take some more time).

You will get an update once they reach to a final decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth area/datasource datasource/MSSQL Microsoft SQL Server Data Source triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced type/feature-request
Projects
Status: Feature Requests
Development

No branches or pull requests

6 participants