-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.1] Backport: [GR-54871] [JDK-8229959] Execute bootstrap methods for Proxy at image build time. #758
Comments
@zakkak We should expedite the backport as this seems to cause a lot of test noise in CI: #742 (comment) |
I backported this along with a rebase of our |
Thanks. Could you create a PR next time, please? This makes it more apparent when changes get included.
Sure. Sounds good. |
On one hand it does make it more apparent, but on the other hand if we are going to rebase the commit hashes referenced in the PR won't be relevant any more and in the case of an upstream backport where our backport PR will be dropped that won't be logged either. I am OK with either approach though. |
My main concern is that we (I) don't notice changes going in. If I hadn't checked the release branch, I wouldn't have seen why you said you've backported it. It's also useful to see CI with a PR running before merging it. Finally, we can collect PRs in a milestone and reference it. For example it would show up in this issue. There would be a history that we've first backported it ourselves, then - potentially - reverted it and included the upstream PR instead.
Please use PRs if you can. Also for "sync with upstream" kind of work. Thank you! |
Noted.
This would only work for merges though, rebases and force pushes can't go through a PR AFAIK. |
This is in the process of being backported upstream as part of oracle#9236 |
Backported with oracle#9236 as oracle@62505d5 |
What would you like to backport?
oracle#9184
Why?
Should fix quarkusio/quarkus#41283 (to be confirmed). We've seen CI test failures related to it on the 24.1 release branch here:
https://github.com/zakkak/mandrel/actions/runs/9685446687/job/26725539358
Are the changes being backported merged in upstream Graal?
The text was updated successfully, but these errors were encountered: