Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gorilla/websocket Loading
base: v1.5.0
Choose a base ref
...
head repository: gorilla/websocket Loading
compare: v1.5.1
Choose a head ref
  • 12 commits
  • 49 files changed
  • 9 contributors

Commits on Feb 16, 2022

  1. Add check for Sec-WebSocket-Key header (#752)

    * add Sec-WebSocket-Key header verification
    
    * add testcase to Sec-WebSocket-Key header verification
    hirasawayuki committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    69d0eb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2022

  1. Changed the method name UnderlyingConn to NetConn to align the method…

    …s names with Go 1.18 standard library (#773)
    JWSong committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    78cf1bc View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Configuration menu
    Copy the full SHA
    27d91a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Check for and report bad protocol in TLSClientConfig.NextProtos (#788)

    * return an error when Dialer.TLSClientConfig.NextProtos contains a protocol that is not http/1.1
    
    * include the likely cause of the error in the error message
    
    * check for nil-ness of Dialer.TLSClientConfig before attempting to run the check
    
    * addressing the review
    
    * move the NextProtos test into a separate file so that it can be run conditionally on go versions >= 1.14
    
    * moving the new error check into existing http response error block to reduce the possibility of false positives
    
    * wrapping the error in %w
    
    * using %v instead of %w for compatibility with older versions of go
    
    * Revert "using %v instead of %w for compatibility with older versions of go"
    
    This reverts commit d34dd94.
    
    * move the unit test back into the existing test code since golang build constraint is no longer necessary
    
    Co-authored-by: Chan Kang <chankang@[email protected]>
    ChannyClaus and Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    bc7ce89 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. check error before GotConn for trace

    Signed-off-by: Ye Sijun <[email protected]>
    junnplus authored and garyburd committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    af47554 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. archive mode

    elithrar committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    76ecc29 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Update README.md

    Signed-off-by: Corey Daley <[email protected]>
    coreydaley committed Jul 15, 2023
    2 Configuration menu
    Copy the full SHA
    931041c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #839 from gorilla/coreydaley-patch-1

    Update README.md
    coreydaley committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    8983b96 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Correct way to save memory using write buffer pool and freeing net.ht…

    …tp default buffers (#761)
    
    **Summary of Changes**
    
    1. Add an example that uses the write buffer pool
    
    The loop process of the websocket connection is inner the http handler
    at existing examples, This usage will cause the 8k buffer(4k read buffer
    + 4k write buffer) allocated by net.http can't be GC(Observed by heap
    profiling, see picture below) . The purpose of saving memory is not
    achieved even if the WriteBufferPool is used.
    
    In example bufferpool, server process websocket connection in a new
    goroutine, and the goroutine created by the net.http will exit, then the
    8k buffer will be GC.
    
    
    ![heap](https://user-images.githubusercontent.com/12793501/148676918-872d1a6d-ce10-4146-ba01-7de114db09f5.png)
    
    Co-authored-by: hakunaliu <[email protected]>
    Co-authored-by: Corey Daley <[email protected]>
    3 people committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8039329 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Update go version & add verification/testing tools (#840)

    Fixes #
    
    **Summary of Changes**
    
    1.
    2. 
    3.
    
    > PS: Make sure your PR includes/updates tests! If you need help with
    this part, just ask!
    coreydaley committed Aug 26, 2023
    3 Configuration menu
    Copy the full SHA
    666c197 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. update golang.org/x/net (#856)

    <!--
    For Work In Progress Pull Requests, please use the Draft PR feature,
    see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
    further details.
    
         For a timely review/response, please avoid force-pushing additional
         commits if your PR already received reviews or comments.
    
         Before submitting a Pull Request, please ensure that you have:
    - 📖 Read the Contributing guide:
    https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md
    - 📖 Read the Code of Conduct:
    https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md
    
         - Provide tests for your changes.
         - Use descriptive commit messages.
    	 - Comment your code where appropriate.
    	 - Squash your commits
         - Update any related documentation.
    
         - Add gorilla/pull-request-reviewers as a Reviewer
    -->
    
    ## What type of PR is this? (check all applicable)
    
    - [ ] Refactor
    - [ ] Feature
    - [ ] Bug Fix
    - [ ] Optimization
    - [ ] Documentation Update
    - [ ] Go Version Update
    - [x] Dependency Update
    
    ## Description
    
    ## Related Tickets & Documents
    
    <!--
    For pull requests that relate or close an issue, please include them
    below. We like to follow [Github's guidance on linking issues to pull
    requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
    
    For example having the text: "closes #1234" would connect the current
    pull
    request to issue 1234.  And when we merge the pull request, Github will
    automatically close the issue.
    -->
    
    - Related Issue #
    - Closes #
    
    ## Added/updated tests?
    
    - [ ] Yes
    - [ ] No, and this is why: _please replace this line with details on why
    tests
          have not been included_
    - [ ] I need help with writing tests
    
    ## Run verifications and test
    
    - [ ] `make verify` is passing
    - [ ] `make test` is passing
    coreydaley committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    78c3487 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. update GitHub workflows (#857)

    <!--
    For Work In Progress Pull Requests, please use the Draft PR feature,
    see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
    further details.
    
         For a timely review/response, please avoid force-pushing additional
         commits if your PR already received reviews or comments.
    
         Before submitting a Pull Request, please ensure that you have:
    - 📖 Read the Contributing guide:
    https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md
    - 📖 Read the Code of Conduct:
    https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md
    
         - Provide tests for your changes.
         - Use descriptive commit messages.
    	 - Comment your code where appropriate.
    	 - Squash your commits
         - Update any related documentation.
    
         - Add gorilla/pull-request-reviewers as a Reviewer
    -->
    
    ## What type of PR is this? (check all applicable)
    
    - [x] Refactor
    - [ ] Feature
    - [ ] Bug Fix
    - [ ] Optimization
    - [ ] Documentation Update
    - [ ] Go Version Update
    - [ ] Dependency Update
    
    ## Description
    
    ## Related Tickets & Documents
    
    <!--
    For pull requests that relate or close an issue, please include them
    below. We like to follow [Github's guidance on linking issues to pull
    requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
    
    For example having the text: "closes #1234" would connect the current
    pull
    request to issue 1234.  And when we merge the pull request, Github will
    automatically close the issue.
    -->
    
    - Related Issue #
    - Closes #
    
    ## Added/updated tests?
    
    - [ ] Yes
    - [ ] No, and this is why: _please replace this line with details on why
    tests
          have not been included_
    - [ ] I need help with writing tests
    
    ## Run verifications and test
    
    - [x] `make verify` is passing
    - [x] `make test` is passing
    coreydaley committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ac0789b View commit details
    Browse the repository at this point in the history
Loading