-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Comparing changes
Open a pull request
base repository: gorilla/websocket
base: v1.5.0
head repository: gorilla/websocket
compare: v1.5.1
- 12 commits
- 49 files changed
- 9 contributors
Commits on Feb 16, 2022
-
Add check for Sec-WebSocket-Key header (#752)
* add Sec-WebSocket-Key header verification * add testcase to Sec-WebSocket-Key header verification
Configuration menu - View commit details
-
Copy full SHA for 69d0eb9 - Browse repository at this point
Copy the full SHA 69d0eb9View commit details
Commits on Apr 17, 2022
-
Changed the method name UnderlyingConn to NetConn to align the method…
…s names with Go 1.18 standard library (#773)
Configuration menu - View commit details
-
Copy full SHA for 78cf1bc - Browse repository at this point
Copy the full SHA 78cf1bcView commit details
Commits on Jun 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 27d91a9 - Browse repository at this point
Copy the full SHA 27d91a9View commit details
Commits on Jun 21, 2022
-
Check for and report bad protocol in TLSClientConfig.NextProtos (#788)
* return an error when Dialer.TLSClientConfig.NextProtos contains a protocol that is not http/1.1 * include the likely cause of the error in the error message * check for nil-ness of Dialer.TLSClientConfig before attempting to run the check * addressing the review * move the NextProtos test into a separate file so that it can be run conditionally on go versions >= 1.14 * moving the new error check into existing http response error block to reduce the possibility of false positives * wrapping the error in %w * using %v instead of %w for compatibility with older versions of go * Revert "using %v instead of %w for compatibility with older versions of go" This reverts commit d34dd94. * move the unit test back into the existing test code since golang build constraint is no longer necessary Co-authored-by: Chan Kang <chankang@[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc7ce89 - Browse repository at this point
Copy the full SHA bc7ce89View commit details
Commits on Jul 12, 2022
-
check error before GotConn for trace
Signed-off-by: Ye Sijun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for af47554 - Browse repository at this point
Copy the full SHA af47554View commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 76ecc29 - Browse repository at this point
Copy the full SHA 76ecc29View commit details
Commits on Jul 15, 2023
-
2
Configuration menu - View commit details
-
Copy full SHA for 931041c - Browse repository at this point
Copy the full SHA 931041cView commit details -
Merge pull request #839 from gorilla/coreydaley-patch-1
Update README.md
Configuration menu - View commit details
-
Copy full SHA for 8983b96 - Browse repository at this point
Copy the full SHA 8983b96View commit details
Commits on Aug 17, 2023
-
Correct way to save memory using write buffer pool and freeing net.ht…
…tp default buffers (#761) **Summary of Changes** 1. Add an example that uses the write buffer pool The loop process of the websocket connection is inner the http handler at existing examples, This usage will cause the 8k buffer(4k read buffer + 4k write buffer) allocated by net.http can't be GC(Observed by heap profiling, see picture below) . The purpose of saving memory is not achieved even if the WriteBufferPool is used. In example bufferpool, server process websocket connection in a new goroutine, and the goroutine created by the net.http will exit, then the 8k buffer will be GC. ![heap](https://user-images.githubusercontent.com/12793501/148676918-872d1a6d-ce10-4146-ba01-7de114db09f5.png) Co-authored-by: hakunaliu <[email protected]> Co-authored-by: Corey Daley <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8039329 - Browse repository at this point
Copy the full SHA 8039329View commit details
Commits on Aug 26, 2023
-
Update go version & add verification/testing tools (#840)
Fixes # **Summary of Changes** 1. 2. 3. > PS: Make sure your PR includes/updates tests! If you need help with this part, just ask!
3Configuration menu - View commit details
-
Copy full SHA for 666c197 - Browse repository at this point
Copy the full SHA 666c197View commit details
Commits on Oct 17, 2023
-
update golang.org/x/net (#856)
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure that you have: - 📖 Read the Contributing guide: https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md - 📖 Read the Code of Conduct: https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md - Provide tests for your changes. - Use descriptive commit messages. - Comment your code where appropriate. - Squash your commits - Update any related documentation. - Add gorilla/pull-request-reviewers as a Reviewer --> ## What type of PR is this? (check all applicable) - [ ] Refactor - [ ] Feature - [ ] Bug Fix - [ ] Optimization - [ ] Documentation Update - [ ] Go Version Update - [x] Dependency Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue # - Closes # ## Added/updated tests? - [ ] Yes - [ ] No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] I need help with writing tests ## Run verifications and test - [ ] `make verify` is passing - [ ] `make test` is passing
Configuration menu - View commit details
-
Copy full SHA for 78c3487 - Browse repository at this point
Copy the full SHA 78c3487View commit details
Commits on Oct 18, 2023
-
update GitHub workflows (#857)
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure that you have: - 📖 Read the Contributing guide: https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md - 📖 Read the Code of Conduct: https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md - Provide tests for your changes. - Use descriptive commit messages. - Comment your code where appropriate. - Squash your commits - Update any related documentation. - Add gorilla/pull-request-reviewers as a Reviewer --> ## What type of PR is this? (check all applicable) - [x] Refactor - [ ] Feature - [ ] Bug Fix - [ ] Optimization - [ ] Documentation Update - [ ] Go Version Update - [ ] Dependency Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue # - Closes # ## Added/updated tests? - [ ] Yes - [ ] No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] I need help with writing tests ## Run verifications and test - [x] `make verify` is passing - [x] `make test` is passing
Configuration menu - View commit details
-
Copy full SHA for ac0789b - Browse repository at this point
Copy the full SHA ac0789bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.5.0...v1.5.1