Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement ES256 for JWT verification #340

Merged
merged 9 commits into from
Apr 1, 2020
Merged

feat: Implement ES256 for JWT verification #340

merged 9 commits into from
Apr 1, 2020

Conversation

theacodes
Copy link
Contributor

Closes #336
Closes #157

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@theacodes theacodes changed the title Implement EC256 for JWT verification Implement ES256 for JWT verification May 9, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 16, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@arithmetic1728 arithmetic1728 changed the title Implement ES256 for JWT verification feat: Implement ES256 for JWT verification Mar 11, 2020
bshaffer
bshaffer reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fantastic. One clarification question, and also, seems like we should add a bit to the ID Token docs

google/auth/jwt.py Show resolved Hide resolved
@arithmetic1728
Copy link
Contributor

This all looks fantastic. One clarification question, and also, seems like we should add a bit to the ID Token docs

Yes. docs are now added.

bshaffer
bshaffer approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@arithmetic1728 arithmetic1728 merged commit e290a3d into master Apr 1, 2020
@arithmetic1728 arithmetic1728 deleted the add-ec256-crypto branch April 1, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 left review comments

@bshaffer bshaffer bshaffer approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWT can't be verified Support Elliptic curve signatures in JWT module
5 participants
@theacodes @arithmetic1728 @bshaffer @googlebot @yoshi-automation