Fixes at-expiration values being nan
#92
Merged
+852
−518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please sync your version to head as well to fix current merge failure? |
|
I synced my fork and I see there is a new commit here, but it looks like copybara is still failing. Is there anything else I need to do? |
|
I just had to rerun copybara manually, so it's all good. Could you please add a test to show that the code does what is intended as well as squash the commits? I will then merge in with the main branch. Thanks! |
|
Thank you, Alex! Could you please run git squash? |
|
I haven't added in the test yet, I only synced my fork with master. I will have the tests done soon and then I will squash the commits and force push. |
alembcke
force-pushed
the
expiration_fix
branch
from
f714f69
to
d8c26a4
Compare
|
OK, test added and squashed commits, I hope I did it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89. Fixes at-expiration values being
nanfor certain option models.Tests were run to ensure that values prior to expiration are not affected. Tests were also run to ensure that execution time was not impacted materially. Bazel tests also passed for all modified functions.