-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor Performance in TensorFlow 2.1 #17
Comments
Hi Kyle! Thanks for putting your efforts to make the example TF2-friendly. We will add benchmarking tools later. As for now here are some remarks:
Hope this helps! |
Thanks for the response @cyrilchim. I've since tested the code on a V100 with a warmup computation and saw significant performance improvements over the old API version. I did still see slightly worse performance on the CPU variation, but I'm also having issues getting TF2.1 compiled with MKL on my instance so could be a cause. Would a pull request with an update to that notebook be appropriate? Or are you planning on waiting for some more benchmarks that you mentioned? |
Hi Kyle, |
I was refactoring the "American_Option_Black_Sholes.ipynb" to use the new
fd_solvers
API with TensorFlow 2.1, but it has much worse performance than in the previous version that was pre-TF2.0.Here is the notebook re-written in eager style and ran on the colab GPU: https://colab.research.google.com/drive/1FVYloxIrSvlSrp1aMPLxN4f4KlvPI8l0
As you can see the CPU and GPU options/sec benchmarks are both around 1/3 what they were in the old notebook saved on the master branch. I've also tried running the same code, but using the
tf.compat.v1
Session and graph; this did not improve performance at all. I've also tried to profile the code usingtf.summary.trace_on(graph=True, profiler=True)
, but it doesn't produce any useful information.Is this performance something I'm doing wrong with my implementation, is there perhaps some better way I can profile the core library for issues, or is this related to some performance issues with TF2.0 itself?
The text was updated successfully, but these errors were encountered: