-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnCanCreateNewOutgoingStream in SpdySession #63
Comments
I have to correct myself; I can not just override the virtual, these session objects are two separate things. But still, the QuicSpdySession, where the code where the call ends after receiving an update. So, I am stuck here and grateful for a pointer on how to pass "OnCanCreateNewOutgoingStream" onto the WebTransportSessionVisitor object. |
Cross linking related chromium bug: |
OK, I could fix it with this: |
In order to see what the issue is, you can look into the test I have written: |
Hi Marten, You're correct that this is a bug (I'll need to fix this). I think this shouldn't affect the production Chrome APIs, since those are defined to immediately fail whenever you exceed the stream limit, and we don't currently have a way to notify the application that new streams are available (it was recently added to the spec, but isn't implemented in our code yet). |
Hi Victor, |
Hi,
I am trying to make unit test for the MAX_STREAM property in my WebTransport lib.
I ran into an issue, if the number of bidirectional streams is increased the visitor was not informed.
I tracked it down to
quiche/quiche/quic/core/http/quic_spdy_session.cc
Line 1619 in 87cb8c8
which does not inform in case of bidrectional streams.
The new generic session does it:
quiche/quiche/quic/core/quic_generic_session.cc
Line 170 in 87cb8c8
It is not a big deal, since I can overload the method, but I am wondering, if it is intentional and if I am missing something.
The text was updated successfully, but these errors were encountered: