Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to access the spdsession object from a WebTransportSession #44

Open
martenrichter opened this issue Jun 10, 2023 · 2 comments
Open

Comments

@martenrichter
Copy link

I would like to support getStats and sending goaway stuff in the node webtransport addon.
However, I am hitting the following problem.
GetStats and as well as sendGoawayHttps3 (needed at least from the server side) are available through the underlying QuicSpdySession.
However, it is a private member of WebTransportHttp3, so I have no way to access it from a visitor.
(My plan is to do a dynamic cast on the WebTransport object....).

Are there any plans to make these features available through the WebTransport base class, or at least to get access to the SpdySession?
(I think deriving a class from WebTransportHttp3 is not an option, since it is created deep within quiche objects?)
Or any hints, on how to do it in another way?
Thanks?

@vasilvv
Copy link
Contributor

vasilvv commented Jun 13, 2023

I don't think there's a public accessor that would let you do this currently. Are you trying to implement the W3C APIs for stats and goaway? If so, I will be adding them at some point soon anyways, since we need those in Chrome.

@martenrichter
Copy link
Author

Are you trying to implement the W3C APIs for stats and goaway?
Yes, this is the intention. Goaway draining is already implemented, thanks to your commit last week, but missing a server equivalent, so not really working or tested without the ability to send it.
Then I will wait....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants