Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong statement in FlexboxLayoutManager.computeScrollOffset() #496

Open
1 task
setsailz opened this issue May 16, 2019 · 0 comments
Open
1 task

Wrong statement in FlexboxLayoutManager.computeScrollOffset() #496

setsailz opened this issue May 16, 2019 · 0 comments

Comments

@setsailz
Copy link

Issues and steps to reproduce

I see code in FlexboxLayoutManager.computeScrollOffset(), line 2261 :

if (firstLinePosition == 0 || firstLinePosition == NO_POSITION) { return 0; }

The first statement 'firstLinePosition == 0' will cause first line return 0 scrollOffset.

Expected behavior

Remove this statement.

Version of the flexbox library

e.g. 1.1.0

Link to code

if (firstLinePosition == NO_POSITION) { return 0; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant