Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tagging submodule "go"? #137

Closed
Rick-xuy opened this issue Feb 18, 2023 · 2 comments
Closed

Consider tagging submodule "go"? #137

Rick-xuy opened this issue Feb 18, 2023 · 2 comments

Comments

@Rick-xuy
Copy link

I found that packages, say github.com/google/fhir/go/proto/google/fhir/proto/annotations_go_proto, are placed in submodule github.com/google/fhir/go instead of root module.

However, it seems that submodule github.com/google/fhir/go is not tagged. According to go docs, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/google/fhir/go/proto/google/fhir/proto/annotations_go_proto, downstream would depends on pseudo-version of module github.com/google/fhir/go.

github.com/google/fhir/go v0.0.0-20230201040735-41722f15f676

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, go/v0.0.1, go/v0.7.4etc, so that other project can use tag to import this module in go.mod.

@nikklassen
Copy link
Member

This sounds totally reasonable, our team isn't super familiar with everything we should do to properly publish Go packages. I'll look into making this change

@nikklassen
Copy link
Member

@suyashkumar we should add this to the release process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants