Unify type adapter / provider representations #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
764ac0f
to
57a22de
Compare
99b1d33
to
ade3030
Compare
jcking
reviewed
Jul 14, 2023
jcking
previously approved these changes
Jul 14, 2023
The ref.TypeAdapter, ref.TypeProvider, and ref.TypeRegistry have been deprecated in favor of types.Adapter, types.Provider, and types.Registry respectively. All existing uses of ref.TypeProvider / ref.TypeAdapter interfaces are wrapped into an interop layer under the covers which ensures that all internal objects refer to the new types and interfaces. This shift marks the deprecation of the last of the exprpb.Type methods, thus simplifying implementation of custom type providers as implementers need only consider the *types.Type and not the ref.Type, exprpb.Type, or any other alternative.
ade3030
to
fc02061
Compare
jcking
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ref.TypeAdapter, ref.TypeProvider, and ref.TypeRegistry have been deprecated in favor of types.Adapter, types.Provider, and types.Registry respectively.
All existing uses of ref.TypeProvider / ref.TypeAdapter interfaces are wrapped into an interop layer under the covers which ensures that all internal objects refer to the new types and interfaces.
This shift marks the deprecation of the last of the exprpb.Type methods, thus simplifying implementation of custom type providers as implementers need only consider the *types.Type and not the ref.Type, exprpb.Type, or any other alternative.
Closes #568