Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for libpfm related tests to Makefile #2631

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

Creatone
Copy link
Collaborator

@Creatone Creatone commented Jul 24, 2020

It must be possible to run libpfm related tests with Makefile.

@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole
Copy link
Collaborator

/retest

@dashpole
Copy link
Collaborator

I0724 16:17:04.048] >> running tests
W0724 16:17:04.151] go test: race flag may be set only once
W0724 16:17:04.153] run "go help test" or "go help testflag" for more information

@Creatone Creatone force-pushed the make-test-go-flags branch 2 times, most recently from bb98e1e to 96cf4e7 Compare July 27, 2020 14:58
@Creatone
Copy link
Collaborator Author

Okk @dashpole, I found better solution for this case.

@Creatone Creatone changed the title Add GO_FLAGS env to test in makefile Add entry for libpfm releated tests to Makefile Jul 27, 2020
@Creatone Creatone changed the title Add entry for libpfm releated tests to Makefile Add entry for libpfm related tests to Makefile Jul 27, 2020
@dashpole dashpole merged commit 33463ad into google:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants