Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-highlight doesn't update for workspace comment move events #2330

Open
1 task done
BeksOmega opened this issue Apr 19, 2024 · 0 comments · May be fixed by #2400
Open
1 task done

Content-highlight doesn't update for workspace comment move events #2330

BeksOmega opened this issue Apr 19, 2024 · 0 comments · May be fixed by #2400
Assignees
Labels
type: bug Something isn't working

Comments

@BeksOmega
Copy link
Contributor

BeksOmega commented Apr 19, 2024

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

workspace-content-highlight

Description

If you move workspace comments or add them to the workspace, they don't update the content highlight. However if you move a block, the content highlight updates to highlight everything including the comments.

Reproduction steps

  1. Load the following JSON into the workspace.
{
  "workspaceComments": [
    {
      "height": 100,
      "width": 120,
      "id": "o`-uR}#Q,qg#1LUorXg5",
      "x": 131.890625,
      "y": 326,
      "text": "Say something..."
    },
    {
      "height": 100,
      "width": 120,
      "id": "*CHb18}Td!%xT~MTvk!N",
      "x": 327.5572814941406,
      "y": 698.3333129882812,
      "text": "Say something..."
    }
  ],
  "blocks": {
    "languageVersion": 0,
    "blocks": [
      {
        "type": "controls_if",
        "id": "0NAT)tSk}AALHd#HIB%x",
        "x": 213,
        "y": 162
      }
    ]
  }
}
  1. Move the comments around.
  2. Observe how the highlight does not update.

Stack trace

No response

Screenshots

No response

Additional Info

This has to be tested against v11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants