-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle to 8.8 and AGP to 8.5.0 #2575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check to see if additional changes are required.
Also, is there a reason if we are updating to these specific versions?
addressed comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you verified compatibility of other dependencies with this agp?
I guess our test suite should be enough ?
Update: Some tests failed which is a good sign!
You might wanna take a quick look at this PR to see what all things were updated: #2064
After taking a look at the failure:
and trying to fix it without updating min sdk version, I realised we do need the ISOChronology class in order to get the localized date time pattern... without using this class, it's possible to generate the date time formatter object that is localized, but we won't be able to get the actually localized pattern e.g. yyyy-mm-dd (by calling the api now an alternative is to not use that as hint text, but instead use a formatted date e.g. 2019-09-12... which might be ok but it will just diverge a bit from the behaviour we have when the entry format string is provided by the questionnaire. so i think the easiest thing to do is actually update the minsdk.. which i think wasn't an issue only because of the build tool wasn't picking it up since the api was indeed introduced in api level 26... so this way we're only making what was already the case explicit... (device on 24 would have had problem with this already). |
We dropped the minSdk (for all libraries) to 24 due to this issue #2077. |
Just to confirm, we're fine raising the min level to 26 |
discussed today at the developers call and no objection so far to this api level change. if we don't hear anything else we'll include this change in the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Update gradle to 8.8 and AGP to 8.5.0
Alternative(s) considered
NA
Type
Builds
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.