Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate hardcoded dimensions to dimens file #407

Closed
Ana2k opened this issue Mar 30, 2021 · 1 comment
Closed

Migrate hardcoded dimensions to dimens file #407

Ana2k opened this issue Mar 30, 2021 · 1 comment
Labels
type:code health

Comments

@Ana2k
Copy link
Contributor

Ana2k commented Mar 30, 2021

Describe the Issue
While exploring the code I found, a lot of dimensions have been hardcoded in the XML files.
These values have been repeatedly used.
To reduce redundancy, and make the UI uniformly styled, we should migrate the dimensions to the dimens value file.

Would you like to work on the issue?
Yes
@jingtang10 jingtang10 linked a pull request Mar 30, 2021 that will close this issue
feat : Migrate hardcoded dimensions to value file #409
Closed
8 tasks
@Ana2k
Copy link
Contributor Author

Ana2k commented Apr 1, 2021

@jingtang10 @deepankarb please review this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:code health
Projects
Android FHIR SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat : Migrate hardcoded dimensions to value file Ana2k/android-fhir
2 participants
@jingtang10 @Ana2k