Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace capitialize() with capitalize(Locale.ROOT) #340

Closed
Manikant25 opened this issue Mar 18, 2021 · 0 comments
Closed

Replace capitialize() with capitalize(Locale.ROOT) #340

Manikant25 opened this issue Mar 18, 2021 · 0 comments

Comments

@Manikant25
Copy link
Contributor

Describe the bug
This is a suggestion given by android studio to use capitalize(Locale.ROOT)
Implicitly using the default locale is a common source of bugs: Use capitalize(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault().

Component
SDC gallery app

To Reproduce
Steps to reproduce the behavior:

  1. Double click shift
  2. Search for ResourceMapper.kt
  3. Scroll down to line 104
  4. See error

Expected behavior
Not as such behavior change.

Screenshots
N/A

Smartphone (please complete the following information):

  • Device: xiaomi mi a3
  • Android version: 11
  • Build number: qssi-user 11 RKQ1.200903.002 V12.0.6.0.RFQMIXM

Additional context
If this is a valid issue, I can send PR.

This was referenced Mar 18, 2021
@jingtang10 jingtang10 linked a pull request Mar 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant