-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy pre-built SNAPSHOT pre-release (dev, unstable) versions of Engine and DataCapture to a Maven repo #2503
Comments
@vorburger what are your thoughts on it? |
@santosh-pingle if I understand this correctly, I think this is a good idea! @icrc-fdeniger which Maven repo would you expect to find such Also, it goes without a saying that this is "unstable". Your internal builds can break from one day to another if you build against a My time for this project is unfortunately more limited than I personally would ideally like it to be - but I'm happy to try to help e.g. at least with code reviewing proposed PRs from community members for this, if @icrc-fdeniger you would like to work on this? |
We fully understand the "unstable" implication and if we use a SNAPSHOT we have to assume :) I can help on this topic but I propably will need some help on the way artifacts publications are done: I can see that some aar resources are pushed to google repository. So my first question was: could we publish SNAPSHOT on google repo as weel ? And I didn't see any publication task in the current repo. So maybe the publication is done via another CI/CD tool. |
My (personal) view, and recommendation how to go about implementing this, is... no. IMHO, an open source project's CI/CD should be completely "open", with all related configuration in the public Git repo of the project - if at all possible. I would therefore recommend that in order to implement this issue, we completely ignore any possibly existing Google internal CI/CD which may be used for publishing releases to a Google Maven repository, and "separately" add a GitHub Action YAML to this repo which simply continuously pushes each commit to this repo's default branch to @santosh-pingle I'm obviously very happy to be "contradicted" 😸 by you (or any other maintainers) about this, if you disagree! |
@vorburger Looking at other google projects and some famous open source android libraries, Sonatype OSS seems to be used a lot for publishing snapshots. Guava (google) : https://github.com/google/guava/blob/master/pom.xml#L282 |
@aditya-07 Sonatype OSS (=AKA "Maven Central") is a possible alternative to GitHub Packages, certainly. However, my (personal) view, and recommendation how to go about implementing this, is still to use GitHub Packages. The reason for this is simply to make this FR simpler to implement, and more "community owned". That's because, with:
For end-users (developers), the results is similar - they just have to add |
|
* push artifacts to github Packages * push artifacts to github Packages * try to use github.run_id * try to use github.run_id * modify comments as suggests by MJ1998 * revert changes as required * revert changes as required * revert changes as required * revert changes as required * Format and language changes in the documentation --------- Co-authored-by: Madhuram Jajoo <[email protected]> Co-authored-by: Jing Tang <[email protected]>
Is your feature request related to a problem? Please describe.
Would like to test easily last development in an Android App based on Open Health Stack
Describe the solution you'd like
a SNAPSHOT version is deployed after a push to main branches.
Describe alternatives you've considered
Build locally the jar.
Would you like to work on the issue?
Tried to find more info on github actions and how jar are currently deployed but didn't find it.
Can work on the solution
The text was updated successfully, but these errors were encountered: