Configurable drop down answer option. #2526
Conversation
AdityaKBhadragond14
requested review from
santosh-pingle and
a team
as code owners
There was a problem hiding this comment.
This is incorrect as per rules in Questionnaire:-
+ Rule: If one or more answerOption is present, initial cannot be present. Use answerOption.initialSelected instead
However we don't even need this. You can override the hyphen string constant in your application and the dropdown will read that value instead of "-" defined in the sdc library.
What you may do is change the name of the string constant from hyphen to maybe default_drop_down_value ?
There was a problem hiding this comment.
i agree with jajoo - instead of using initial answers, just provide a way for the user to override the string resource in the xml file. what you might want to do is to give that string a better name. and in the same pr please update the documentation in the docs/ folder or sdc library.
| val initialAnswerString = | ||
| if (questionnaireViewItem.questionnaireItem.hasInitial()) { | ||
| questionnaireViewItem.questionnaireItem.initial.first().valueStringType.valueAsString | ||
| } else { | ||
| context.getString(R.string.hyphen) | ||
| } |
There was a problem hiding this comment.
the initial answer is not something the ui shoudl get involved with. the questionnaire view model should have already handled this.
| initialAnswerString, | ||
| initialAnswerString, |
There was a problem hiding this comment.
one thing you do want to be careful is that if there's a clash between the user defined default value and one of the answer options from the questionnaire. in this case you might want to have a mechanism to give them distinct names -- this is a very very edge case though and i'm happy for you to just add a todo in the code.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2505
Description
In the DropDownViewHolderFactory the hyphen("-") is being set as the default answer option to the drop down. Instead of setting it a fixed answer I have made it configurable. To change the default answer option the questionnaire item representing the drop down item will have the initial property which will have a valueString. The default answer option will be filled with the initial property value if available else it will be filled hyphen("-").
This approach ensures that the configuration will be done via questionnaire itself and the code need be changed everytime to change a default answer option.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Bug Fix.
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.