-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsequent OneTime sync triggers always start with CurrentSyncJobStatus.SUCCEDED status #2472
Labels
Comments
Thanks @ndegwamartin for identifying this. |
This was referenced Mar 13, 2024
Looking into it. |
7 tasks
@ndegwamartin Can you please check whether the issue is fixed with this change #2511 |
Yeah this fixes it, left a comment on the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When One time sync is triggered again, the state is first retrieved from the
syncJobStatusFromWorkManager
(screenshot). A null check is performed and if the state returned is null the state is retrieved from the sync job status datastore. This will hold the status of the previous one time sync.This means that on subsequent one time syncs, we have no way of capturing the state that a new sync has started. This is important so that for instance we can show a UI that shows Sync process is starting. The main issue with the UX is that every time we trigger it subsequently, it first shows a Sync complete dialog then it proceds to do the actual sync after which it shows the sync complete dialog again.
Component
Core library
To Reproduce
Steps to reproduce the behavior:
Expected behavior
We should always return a job status like
Running.Started
orEnqueued
for every fresh onetime sync trigger in order to update UX accordingly.Screenshots
Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.
Would you like to work on the issue?
Sure, however @santosh-pingle recently worked on the original feature
The text was updated successfully, but these errors were encountered: