Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questionnaire content style customization #2353

Closed
Rkareko opened this issue Dec 6, 2023 · 3 comments · Fixed by #2384
Closed

Questionnaire content style customization #2353

Rkareko opened this issue Dec 6, 2023 · 3 comments · Fixed by #2384
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue ux

Comments

@Rkareko
Copy link

Rkareko commented Dec 6, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
It's not possible to customize the padding for the RecyclerView that contains the questionnaire content.

Describe the solution you'd like
FHIRCore has a UX design update that requires modifying the padding around the questionnaire content. To achieve this, the proposal is to add a style to the RecyclerView that will allow for customization.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This is related to the UX Questionnaire adjustments on FHIRCore Styling update to forms

Updated design
questionnaire_content_padding

questionnaire_button_padding

questionnaire_button_text_padding

Would you like to work on the issue?
Yes.
@Rkareko
Copy link
Author

Rkareko commented Dec 6, 2023

@shelaghm Kindly share your thoughts on this UI change cc @f-odhiambo @HenryRae

@Rkareko Rkareko mentioned this issue Dec 7, 2023
Closed
@santosh-pingle santosh-pingle added P2 Medium priority issue effort:xsmall Extra small effort - 1 day ux labels Dec 11, 2023
@shelaghm
Copy link

@Rkareko @f-odhiambo @HenryRae this proposed change looks good to me from the design side. Padding is consistent with our design guidelines.

@sharon2719 sharon2719 mentioned this issue Dec 20, 2023
Merged
7 tasks
@f-odhiambo
Copy link
Collaborator

sharon2719 is working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue ux
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update questionnaire buttons in xml fragment opensrp/android-fhir
4 participants
@f-odhiambo @Rkareko @santosh-pingle @shelaghm