Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal, Open choice view does not show fly-over text. #1516

Closed
santosh-pingle opened this issue Jul 28, 2022 · 5 comments · Fixed by #1625
Closed

Modal, Open choice view does not show fly-over text. #1516

santosh-pingle opened this issue Jul 28, 2022 · 5 comments · Fixed by #1625
Assignees
Labels
effort:small Small effort - 2 days P1 High priority issue type:bug Something isn't working ux

Comments

@santosh-pingle
Copy link
Collaborator

Describe the bug
Modal and open choice view does not show fly over text on inclusion of flyover code to questionnaire-itemControl extension.

e.g
"extension": [
{
"url": "http:https://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
"valueCodeableConcept": {
"coding": [
{
"system": "http:https://hl7.org/fhir/questionnaire-item-control",
"code": "flyover",
"display": "Fly-over"
}
],
"text": "Flyover"
}
}
]

Component
SDC library

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
flyover text should be shown.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle
Copy link
Collaborator Author

@shelaghm is it okay to have this change in sdc module?

@shelaghm
Copy link

shelaghm commented Aug 3, 2022

@santosh-pingle yes, updating in SDC module/library sounds good to me.

@Tarun-Bhardwaj Tarun-Bhardwaj added type:bug Something isn't working P1 High priority issue effort:small Small effort - 2 days and removed To be triaged labels Sep 14, 2022
@PallaviGanorkar PallaviGanorkar self-assigned this Sep 22, 2022
@santosh-pingle
Copy link
Collaborator Author

@PallaviGanorkar
Flyover text is missing from below screenshot.
Screen Shot 2022-09-22 at 3 46 43 PM

You can refer Dropdown component workflow to get expected workflow, where flyover text is shown.
Just attaching screenshot for reference.

Screen Shot 2022-09-22 at 3 50 21 PM

@PallaviGanorkar
Copy link
Contributor

PallaviGanorkar commented Sep 23, 2022

@shelaghm I have added "Health conditions" as flyover text for open choice component in Catalog app (see attachment below). Please let me know if you have other thoughts. Thanks!
FlyoverForOpenChoiceView

@shelaghm
Copy link

@PallaviGanorkar Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:small Small effort - 2 days P1 High priority issue type:bug Something isn't working ux
Projects
Status: Complete
4 participants