Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to retrieving number of dropped frames / duration from the exoplayer instance when SkipSilence audio processor is used #5666

Open
theboubougne opened this issue Mar 21, 2019 · 3 comments

Comments

@theboubougne
Copy link

theboubougne commented Mar 21, 2019

[REQUIRED] Use case description

I'm currently using the Skip silence audio processor but I'm unable to retrieve the number of dropped frames from the exoplayer instance.
This would be a nice feature to provide stats and feedback to the user

Proposed solution

Maybe adding a new callback in AnalyticsListener could be a solution

Alternatives considered

Duplicating the Skip Silence Audio processor to then add it to the RenderedFactory can work, but it's not ideal

@google-oss-bot
Copy link
Collaborator

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@andrewlewis
Copy link
Collaborator

Just duplicating the SilenceSkippingAudioProcessor likely won't work because the player position needs to account for the skipped frame count. It should work to inject a DefaultAudioProcessorChain to DefaultAudioSink and access its skipped output frame count, but this is not very convenient as you need to know the audio format and the getter needs to be called on the playback thread.

@andrewlewis
Copy link
Collaborator

How would you envisage a listener callback for this would work? It seems it might make more sense to have this work via DecoderCounters, or in the same way. I'll mark this as a low priority enhancement for now as it's unlikely we will get round to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants