Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata track not selected when allow chunkless preparation is true #4016

Closed
scottfennell opened this issue Mar 21, 2018 · 3 comments
Closed
Assignees

Comments

@scottfennell
Copy link

Issue description

When utilizing the setAllowChunklessPreparation(true) for an HLS source timed ID3 metadata is not identified and the onMetadata callback is never called. It appears that a metadata source track is never identified when no sample chunks are downloaded. The DefaultTrackSelector.selectTracks output does not contain any metadata tracks and the Metadata renderer is never enabled.

Reproduction steps

Create a player that utilizes the setAllowChunlessPreparation for HLS with a onMetadata callback on the player - the onMetadata callback will never get called

new HlsMediaSource.Factory(dataSourceFactory)
    .setAllowChunklessPreparation(true)
    .createMediaSource(uri, mainHandler, eventLogger)

Version of ExoPlayer being used

2.7.0

Device(s) and version(s) of Android being used

Pixel 2 XL Oreo + various emulators

@AquilesCanta
Copy link
Contributor

Hi @scottfennell, great to know you are using chunkless preparation. This is a known limitation, listed in our medium post:

ID3 tracks are not supported (there is no spec-defined way to declare ID3 tracks in playlists).

I will mark this as an enhancement, since one of the options we considered was preemptively declaring a track, like the TS extractor does. A commit ref will appear here once we push the workaround.

@AquilesCanta AquilesCanta self-assigned this Mar 22, 2018
ojw28 pushed a commit that referenced this issue May 7, 2018
@ojw28
Copy link
Contributor

ojw28 commented May 7, 2018

I believe this can be marked as fixed (@AquilesCanta - Please re-open if there's more to do)

@ojw28 ojw28 closed this as completed May 7, 2018
@AquilesCanta
Copy link
Contributor

Please let us know if you run into any issues with ID3 while using chunkless preparation.

@google google locked and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants