-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata track not selected when allow chunkless preparation is true #4016
Comments
Hi @scottfennell, great to know you are using chunkless preparation. This is a known limitation, listed in our medium post:
I will mark this as an enhancement, since one of the options we considered was preemptively declaring a track, like the TS extractor does. A commit ref will appear here once we push the workaround. |
Issue:#3149 Issue:#4016 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=193664294
I believe this can be marked as fixed (@AquilesCanta - Please re-open if there's more to do) |
Please let us know if you run into any issues with ID3 while using chunkless preparation. |
Issue description
When utilizing the
setAllowChunklessPreparation(true)
for an HLS source timed ID3 metadata is not identified and the onMetadata callback is never called. It appears that a metadata source track is never identified when no sample chunks are downloaded. The DefaultTrackSelector.selectTracks output does not contain any metadata tracks and the Metadata renderer is never enabled.Reproduction steps
Create a player that utilizes the setAllowChunlessPreparation for HLS with a onMetadata callback on the player - the onMetadata callback will never get called
Version of ExoPlayer being used
2.7.0
Device(s) and version(s) of Android being used
Pixel 2 XL Oreo + various emulators
The text was updated successfully, but these errors were encountered: