Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior with ending symbols #15

Closed
mitya52 opened this issue May 1, 2022 · 2 comments
Closed

Unexpected behavior with ending symbols #15

mitya52 opened this issue May 1, 2022 · 2 comments

Comments

@mitya52
Copy link

mitya52 commented May 1, 2022

Hi again,

I found that count-occurrences have an unexpected behavior if you want to count last symbols in sequence. Here are the examples:

  • sequence "aaabbb", query "b": expect 3, but output is Number of times present: 2
  • another one is when sequence "aaabbb", query "bb": expected 2, but actual output is Number of times present: 0

Can you fix this? Thanks!

@carlini carlini closed this as completed in 0008e61 May 1, 2022
@carlini
Copy link
Collaborator

carlini commented May 1, 2022

Thanks for catching this. It should be good now with 0008e61, I had previously unintentionally ignored the last N bytes for a file of length for queries of length N. This was a bug in the old code (it should have only ignored the last N-1 bytes) but now as part of the fix for #14 I don't need any length cap.

@mitya52
Copy link
Author

mitya52 commented May 1, 2022

I think you forgot to fix same workaround upper in line 286. When I patched it, all started to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants