Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.11.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.0
Choose a head ref
  • 13 commits
  • 28 files changed
  • 5 contributors

Commits on Jun 13, 2023

  1. idna: update for Unicode 15.0.0

    Changes entirely automated, the result of running
    
    	cd src/golang.org/x/text
    	go generate ./...
    
    (which also edits x/net for us).
    
    For golang/go#55079.
    
    Change-Id: I6a638949ff2c53bc98c635e5e3b5ed672b51d71a
    Reviewed-on: https://go-review.googlesource.com/c/net/+/503055
    Run-TryBot: Russ Cox <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    rsc authored and gopherbot committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f5464dd View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. html: handle equals sign before attribute

    Apply the correct normalization when an equals sign appears before an
    attribute name (e.g. '<tag =>' -> '<tag =="">'), per WHATWG 13.2.5.32.
    
    Change-Id: Id21b428bd86117dd073c502767386bc718a3fb7b
    Reviewed-on: https://go-review.googlesource.com/c/net/+/488695
    Auto-Submit: Roland Shoemaker <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Nigel Tao <[email protected]>
    Run-TryBot: Roland Shoemaker <[email protected]>
    Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <[email protected]>
    rolandshoemaker authored and gopherbot committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4050002 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. quic: add congestion controller

    Implement the NewReno-derived congestion controller from
    RFC 9002, Section 7.
    
    For golang/go#58547
    
    Change-Id: I5280c4ad040be22eb16f79a29d2daf5ba62d1169
    Reviewed-on: https://go-review.googlesource.com/c/net/+/499640
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    neild committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    508a573 View commit details
    Browse the repository at this point in the history
  2. quic: rename side type to connSide

    The clearest name for vars of this type is often "side",
    so make the type name distinct to avoid conflicts.
    
    For golang/go#58547
    
    Change-Id: I35fda7ae70e54cd063bae7a83bcb2c8f5f76244f
    Reviewed-on: https://go-review.googlesource.com/c/net/+/501375
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ab184e6 View commit details
    Browse the repository at this point in the history
  3. quic: correct rttvar updates

    RFC errata 7539 adjusts RFC 9002 Section 5.3 to update
    rttvar before smoothed_rtt.
    
    https://www.rfc-editor.org/errata/eid7539
    
    For golang/go#58547
    
    Change-Id: I154ed54d3d693c3b42355de39c5907c7cc906fde
    Reviewed-on: https://go-review.googlesource.com/c/net/+/502215
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ee81e8c View commit details
    Browse the repository at this point in the history
  4. quic: add packetFate enum

    Packets sent by an endpoint are ultimately acknowledged by the peer
    or declared lost. When a packet is acked or lost, we will look
    through the data it contained and either mark it as received
    by the peer or resend it.
    
    Add an enum for the fate of a sent packet: acked or lost.
    
    Update the sentVal ackOrLoss function to take a packetFate
    rather than a bool.
    
    For golang/go#58547
    
    Change-Id: I2e526308db2c03b9c44b59ede1ce84684392c576
    Reviewed-on: https://go-review.googlesource.com/c/net/+/504615
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    neild committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5d50b40 View commit details
    Browse the repository at this point in the history
  5. quic: remove stray debugging print

    For golang/go#58547
    
    Change-Id: Ieca0569b23972d581e3bfc828c28eb2929f62c25
    Reviewed-on: https://go-review.googlesource.com/c/net/+/504616
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c8a2c5a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. quic: loss detection

    Implement the loss detection algorithm from RFC 9002, Section 6.
    
    For golang/go#58547
    
    Change-Id: I9bec21fc0ec1e48f0421f2c365fc17a1b8988b2f
    Reviewed-on: https://go-review.googlesource.com/c/net/+/499641
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    neild committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    02fe9a5 View commit details
    Browse the repository at this point in the history
  2. quic: move ack_delay_exponent handling out of frame parsing

    The ACK Delay field of ACK frames contains a duration.
    The field contains an integer which is multiplied by two to the
    power of the sender's ack_delay_exponent transport parameter to
    arrive at the delay in microseconds.
    
    Change the frame parsing and encoding layer to operate on the
    unscaled field value, rather than passing the ack_delay_exponent
    and a duration. This better expresses the fact that we may
    parse an ACK frame without knowing the ack_delay_exponent, if
    the ACK is received before transport parameters.
    
    For golang/go#58547
    
    Change-Id: Ic26256761961ce89aea0618b849e5661b0502b12
    Reviewed-on: https://go-review.googlesource.com/c/net/+/504855
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    neild committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    952fc9c View commit details
    Browse the repository at this point in the history
  3. quic: pass the connection ID length into 1-RTT packet parsing

    1-RTT packets contain a variable-length connection ID field, but
    no indication of the length of the connection ID.  The recipient
    of the packet has chosen the connection ID, and is expected to
    either choose a consistent length or encode the length in the
    connection ID.
    
    Change the parse1RTTPacket function to take the connection ID
    length as an input, rather than assuming that all 1-RTT packets
    contain our hardcoded connection ID length.
    
    This permits using parse1RTTPacket in tests which may create
    and parse packets using other lengths.
    
    For golang/go#58547
    
    Change-Id: I9d09e4a0041051be1604c9146f6db9ca959ad696
    Reviewed-on: https://go-review.googlesource.com/c/net/+/504856
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1bb09e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. http2: validate Host header before sending

    Verify that the Host header we send is valid.
    Avoids sending a request that the server will reject,
    possibly sending us into a retry loop.
    
    No test in this CL, but this will be covered by the net/http
    test added in CL 506996.
    
    For golang/go#60374
    
    Change-Id: I78867eb05293ad8ca1b02bc22fb626760949d4b8
    Reviewed-on: https://go-review.googlesource.com/c/net/+/506995
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Tatiana Bradley <[email protected]>
    neild committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    63727cc View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. http2: revert Transport change from CL 486156

    https://go.dev/cl/486156 was problematic, breaking applications
    like load balancers where cancellations are normal. We tried
    reverting only part of that change but it turns out all three of
    the cancellation paths tainting the connection were wrong and
    could ultimately be triggered by a request cancellation.
    
    We need a different solution for golang/go#59690 which we'll now reopen.
    
    This isn't a straight revert of CL 486156 because subsequent changes
    (CL 496335) depended on its cancelRequest closure, so this was
    reverted by hand.
    
    Fixes golang/go#60818
    Updates golang/go#59690 (no longer fixed)
    
    Change-Id: Ic83b746d7cf89d07655d9efbd04b4d957487cb35
    Reviewed-on: https://go-review.googlesource.com/c/net/+/507395
    Reviewed-by: Damien Neil <[email protected]>
    Run-TryBot: Brad Fitzpatrick <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    bradfitz committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    4fc2eb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: If0420bf8dcbd061d164f2fdafaa45a62a3593f32
    Reviewed-on: https://go-review.googlesource.com/c/net/+/507838
    Reviewed-by: Carlos Amedee <[email protected]>
    Run-TryBot: Gopher Robot <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c73c09c View commit details
    Browse the repository at this point in the history
Loading