Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: TestMmapPtr fails with "Munmap: invalid argument" on GOOS=openbsd #68181

Closed
dmitshur opened this issue Jun 25, 2024 · 3 comments
Closed

x/sys/unix: TestMmapPtr fails with "Munmap: invalid argument" on GOOS=openbsd #68181

dmitshur opened this issue Jun 25, 2024 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

This functionality and test was recently added in CL 592415. It fails on GOOS=openbsd specifically:

=== RUN   TestMmapPtr
    mmap_unix_test.go:72: Munmap: invalid argument
--- FAIL: TestMmapPtr (0.00s)

(From https://ci.chromium.org/b/8744139430297328801.)

CC @golang/openbsd, @ncruces.
@dmitshur dmitshur added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 25, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jun 25, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 25, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp mentioned this issue Jun 25, 2024
Closed
@ncruces ncruces mentioned this issue Jun 26, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595095 mentions this issue: unix: fix MmapPtr test failing on OpenBSD

@ncruces
Copy link
Contributor

ncruces commented Jun 26, 2024

So this should be fixed in golang/sys#199

I ran a GitHub action on a branch that stacks both fixes, and all tests pass on:

  • linux
  • darwin
  • freebsd
  • openbsd
  • netbsd
  • illumos

So, hopefully, this doesn't cause any more issues.

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 26, 2024
@ianlancetaylor ianlancetaylor mentioned this issue Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

unix: fix MmapPtr test failing on OpenBSD ncruces/go-sys
4 participants
@dmitshur @ncruces @gopherbot @gabyhelp