Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: OutgoingCalls mishandles dynamic function calls #68153

Open
adonovan opened this issue Jun 24, 2024 · 1 comment
Open

x/tools/gopls: OutgoingCalls mishandles dynamic function calls #68153

adonovan opened this issue Jun 24, 2024 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

adonovan commented Jun 24, 2024

Screenshot 2024-06-24 at 12 57 11 PM

Observe that the "outgoing calls" view shows edges from the site of the call f(). (The target of the call appears to be a node equivalent to the enclosing node for Foo, which is just wrong; the target of the call is obviously unknown.) OutgoingCalls should not report dynamic calls.

Notice too that the order in which outgoing calls are listed appears to be nondeterministic.

@adonovan adonovan added this to the gopls/v0.17.0 milestone Jun 24, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 24, 2024
@adonovan adonovan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 24, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants