x/tools/go/analysis/passes/asmdecl: TestVetStdlib failures on loong64

[abner-chenc]

Go version

go version devel go1.23-45446c867a Tue Jun 18 01:40:18 2024 +0000 linux/loong64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='loong64'
GOBIN=''
GOCACHE='/tmp/abner/gocache'
GOENV='/home/data/chenguoqi/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='loong64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/data/chenguoqi/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/data/chenguoqi/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/data/chenguoqi/golang/go-upstream'
GOSUMDB='sum.golang.org'
GOTMPDIR='/tmp/abner/gotmp'
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/data/chenguoqi/golang/go-upstream/pkg/tool/linux_loong64'
GOVCS=''
GOVERSION='devel go1.23-45446c867a Tue Jun 18 01:40:18 2024 +0000'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/data/chenguoqi/.config/go/telemetry'
GCCGO='gccgo'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/data/chenguoqi/golang/tools/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -mabi=lp64d -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/abner/gotmp/go-build414030735=/tmp/go-build -gno-record-gcc-switches'

What did you do?

git clone https://go.googlesource.com/tools && cd tools && go test -v ./...

What did you see happen?

ok golang.org/x/tools/go/analysis/passes/unusedresult 5.221s
ok golang.org/x/tools/go/analysis/passes/unusedwrite 1.254s
ok golang.org/x/tools/go/analysis/passes/usesgenerics 1.082s
--- FAIL: TestVetStdlib (9.11s)
vet_std_test.go:101: go vet std failed (exit status 1):
# internal/bytealg
../../../../go-upstream/src/internal/bytealg/indexbyte_loong64.s:26:1: [loong64] IndexByte: RET without writing to result register
../../../../go-upstream/src/internal/bytealg/indexbyte_loong64.s:30:1: [loong64] IndexByte: RET without writing to result register
../../../../go-upstream/src/internal/bytealg/indexbyte_loong64.s:48:1: [loong64] IndexByteString: RET without writing to result register
../../../../go-upstream/src/internal/bytealg/indexbyte_loong64.s:52:1: [loong64] IndexByteString: RET without writing to result register
FAIL
FAIL golang.org/x/tools/go/analysis/unitchecker 27.697s
ok golang.org/x/tools/go/ast/astutil 0.163s
ok golang.org/x/tools/go/ast/inspector 0.550s
ok golang.org/x/tools/go/buildutil 3.829s
ok golang.org/x/tools/go/callgraph 0.029s [no tests to run]

What did you expect to see?

all test pass

[gabyhelp]

Similar Issues

• cmd/go: internal/test.test build faild on linux/loong64 #67538
• all: `go tool dist test -asan` fails many tests #64257
• x/tools/go/analysis/unitchecker,slices: `TestVetStdlib` failing due to vet errors in panic tests #64978
• main.x: relocation target main.zero not defined #39859
• runtime/debug: TestStack fail #65506
• compile/arm64: go test fail for arm64 #37181
• cmd/vendor/golang.org/x/arch/arm/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata FAIL #28578
• cmd/go: git tip fails to pass all.bash's build-time tests on Fedora 27 from commit afd090c0 #23337
• cmd/link: need to handle new-style loong64 relocs #63725
• x/tools/gopls: TestAssembly failed with CALL/RET not found on riscv64 #67960

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/593275 mentions this issue: go/analysis/passes/asmdecl: define register-ABI result registers for loong64