Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: enable type-checking using the new Alias types #66864

Closed
griesemer opened this issue Apr 16, 2024 · 3 comments
Closed

cmd/compile: enable type-checking using the new Alias types #66864

griesemer opened this issue Apr 16, 2024 · 3 comments
Assignees
@griesemer
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.23

Comments

@griesemer
Copy link
Contributor

Reminder issue that the compiler currently sets GODEBUG=gotypesalias=0 to avoid a panic during bootstrap (make.bash).
See cmd/compile/internal/noder/irgen.go:92.
@griesemer griesemer added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Apr 16, 2024
@griesemer griesemer added this to the Go1.23 milestone Apr 16, 2024
@griesemer griesemer self-assigned this Apr 16, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 16, 2024
@mengzhuo mengzhuo mentioned this issue Apr 19, 2024
Closed
@cherrymui
Copy link
Member

@griesemer this is marked as a release blocker. Any update on this? Thanks.

@griesemer
Copy link
Contributor Author

The compiler's use of Alias types is still disabled due to #66873.
This is a high priority item at this point.

@griesemer
Copy link
Contributor Author

#66873 was fixed with https://go.dev/cl/585399 which also enabled the use of Alias types in the compiler; i.e., this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@griesemer @gopherbot @cherrymui