Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iter: TestPull failures #66017

Closed
gopherbot opened this issue Feb 29, 2024 · 17 comments
Closed

iter: TestPull failures #66017

gopherbot opened this issue Feb 29, 2024 · 17 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Feb 29, 2024 •
edited by cherrymui
Loading 

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestPull/2
    pull_test.go:48: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:56: have 0 extra goroutines, want 1
    pull_test.go:59: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:68: have -1 extra goroutines, want 0
    pull_test.go:73: have -1 extra goroutines, want 0
--- FAIL: TestPull/2 (0.01s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 29, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "iter:iter" && test == "TestPull/2"
2024-02-27 23:58 gotip-darwin-amd64_13 go@96e9838f iter:iter.TestPull/2 (log) 
=== RUN   TestPull/2
    pull_test.go:48: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:56: have 0 extra goroutines, want 1
    pull_test.go:59: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:68: have -1 extra goroutines, want 0
    pull_test.go:73: have -1 extra goroutines, want 0
--- FAIL: TestPull/2 (0.01s)

— watchflakes

@cherrymui cherrymui changed the title iter:iter: TestPull/2 failures iter: TestPull/2 failures Feb 29, 2024
@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 29, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 6, 2024

I think this test might just have an issue with background goroutines getting spawned or exiting. It shouldn't happen often but I suppose it can happen (e.g. a goroutine that is presumed to exit after it unblocked on a channel actually took a long time to unblock on it, or something).

@mknyszek mknyszek added this to the Backlog milestone Mar 6, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 6, 2024

CC @rsc maybe?

@cherrymui cherrymui mentioned this issue Mar 15, 2024
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull/`
2024-03-15 03:39 gotip-darwin-amd64_13 go@453cbb8f iter:iter.TestPull/3 (log) 
=== RUN   TestPull/3
    pull_test.go:48: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:56: have 0 extra goroutines, want 1
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:68: have -1 extra goroutines, want 0
    pull_test.go:73: have -1 extra goroutines, want 0
--- FAIL: TestPull/3 (0.00s)

— watchflakes

@cherrymui cherrymui changed the title iter: TestPull/2 failures iter: TestPull failures May 6, 2024
@cherrymui cherrymui mentioned this issue May 6, 2024
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-06 15:34 gotip-darwin-amd64_14 go@3c72dd51 iter:iter.TestPull2/0 (log) 
=== RUN   TestPull2/0
    pull_test.go:90: have 0 extra goroutines, want 1
    pull_test.go:98: have 0 extra goroutines, want 1
    pull_test.go:101: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:110: have -1 extra goroutines, want 0
    pull_test.go:115: have -1 extra goroutines, want 0
--- FAIL: TestPull2/0 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-07 18:36 netbsd-386-9_3 go@709d6d5d iter.TestPull2 (log) 
--- FAIL: TestPull2 (0.00s)
    --- FAIL: TestPull2/0 (0.00s)
        pull_test.go:88: have 0 extra goroutines, want 1
        pull_test.go:96: have 0 extra goroutines, want 1
        pull_test.go:99: have -1 extra goroutines, want 0
        pull_test.go:106: have -1 extra goroutines, want 0
        pull_test.go:106: have -1 extra goroutines, want 0
        pull_test.go:108: have -1 extra goroutines, want 0
        pull_test.go:113: have -1 extra goroutines, want 0

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-07 15:21 gotip-darwin-amd64-longtest go@38ee0c76 iter.TestPull/3 (log) 
=== RUN   TestPull/3
    pull_test.go:46: have 0 extra goroutines, want 1
    pull_test.go:52: have 0 extra goroutines, want 1
    pull_test.go:52: have 0 extra goroutines, want 1
    pull_test.go:52: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:64: have -1 extra goroutines, want 0
    pull_test.go:64: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:71: have -1 extra goroutines, want 0
--- FAIL: TestPull/3 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-08 19:10 gotip-linux-arm64-race go@69e75c85 iter.TestPull2/1 (log) 
=== RUN   TestPull2/1
    pull_test.go:94: have 0 extra goroutines, want 1
    pull_test.go:96: have 0 extra goroutines, want 1
    pull_test.go:99: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:113: have -1 extra goroutines, want 0
--- FAIL: TestPull2/1 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-17 00:11 gotip-linux-amd64-race go@69105d79 iter.TestPull2/3 (log) 
=== RUN   TestPull2/3
    pull_test.go:94: have 0 extra goroutines, want 1
    pull_test.go:94: have 0 extra goroutines, want 1
    pull_test.go:94: have 0 extra goroutines, want 1
    pull_test.go:96: have 0 extra goroutines, want 1
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:113: have -1 extra goroutines, want 0
--- FAIL: TestPull2/3 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-15 21:51 gotip-freebsd-riscv64 go@13d36a9b iter.TestPull2/0 (log) 
=== RUN   TestPull2/0
    pull_test.go:88: have 0 extra goroutines, want 1
    pull_test.go:96: have 0 extra goroutines, want 1
    pull_test.go:99: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:113: have -1 extra goroutines, want 0
--- FAIL: TestPull2/0 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-17 17:15 gotip-darwin-amd64_13 go@01ad44bc iter:iter.TestPull/2 (log) 
=== RUN   TestPull/2
    pull_test.go:46: have 0 extra goroutines, want 1
    pull_test.go:52: have 0 extra goroutines, want 1
    pull_test.go:52: have 0 extra goroutines, want 1
    pull_test.go:54: have 0 extra goroutines, want 1
    pull_test.go:57: have -1 extra goroutines, want 0
    pull_test.go:64: have -1 extra goroutines, want 0
    pull_test.go:64: have -1 extra goroutines, want 0
    pull_test.go:66: have -1 extra goroutines, want 0
    pull_test.go:71: have -1 extra goroutines, want 0
--- FAIL: TestPull/2 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-22 13:40 gotip-linux-arm64-boringcrypto go@bb2b7363 iter.TestPull2/0 (log) 
=== RUN   TestPull2/0
    pull_test.go:88: have 0 extra goroutines, want 1
    pull_test.go:96: have 0 extra goroutines, want 1
    pull_test.go:99: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:106: have -1 extra goroutines, want 0
    pull_test.go:108: have -1 extra goroutines, want 0
    pull_test.go:113: have -1 extra goroutines, want 0
--- FAIL: TestPull2/0 (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/587917 mentions this issue: iter: deflake TestPull by letting exiting goroutines finish

This was referenced Jun 21, 2024
Closed
Closed
Closed
Closed
@ianlancetaylor
Copy link
Contributor

This is still happening.

@ianlancetaylor
Copy link
Contributor

#68118
#68119
#68120

@mknyszek
Copy link
Contributor

This is still happening.

I'm not sure it is. All the reported failures in #68118, #68119, and #68120 are from mid-May, before this was fixed on May 24th. I don't know why watchflakes only recently opened issues for these failures, but I don't think there's anything to do here. Closing, but if I got something wrong please feel free to reopen.

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2024
@ianlancetaylor
Copy link
Contributor

Ah ha, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Done
Test Flakes
Archived in project
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mknyszek @ianlancetaylor @bcmills @gopherbot