Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto Loading
base: v0.21.0
Choose a base ref
...
head repository: golang/crypto Loading
compare: v0.23.0
Choose a head ref
  • 9 commits
  • 14 files changed
  • 6 contributors

Commits on Mar 18, 2024

  1. all: remove redundant words in comments and fix some typos

    Change-Id: I3078492dc020770aca630e0b362df0212bd41e32
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/569156
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Nicola Murino <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Nicola Murino <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    cuishuang authored and gopherbot committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b91329d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. x/crypto/chacha20: cleanup chacha_ppc64le.s

    - Adding PCALIGN before the loops
    - Changing WORD directive with corresponding Vector Merge EVEN/ODD word  instructions
    - Replacing Branch Conditional (BC) with its extended mnemonic form  BDNZ
    - VPERMXOR instruction usage in place of VXOR instructions followed by
      VRLW (rotate left) for cases of rotating in multiples of 8. This
      replacements give performace improvement both in time and space  of around 7%-8% as listed below
      using benchstat tool.
    
    goos: linux
    goarch: ppc64le
    pkg: golang.org/x/crypto/chacha20
    cpu: POWER10
                     | chacha20.prev.out |       chacha20.new.out            |
                     |      sec/op       |   sec/op     vs base              |
    ChaCha20/64              171.9n ± 0%   156.6n ± 1%  -8.90% (p=0.002 n=6)
    ChaCha20/256             165.5n ± 0%   152.4n ± 0%  -7.92% (p=0.002 n=6)
    ChaCha20/10x25           505.8n ± 0%   504.3n ± 2%  -0.32% (p=0.589 n=6)
    ChaCha20/4096            2.265µ ± 0%   2.052µ ± 0%  -9.40% (p=0.002 n=6)
    ChaCha20/100x40          5.359µ ± 3%   5.018µ ± 2%  -6.37% (p=0.002 n=6)
    ChaCha20/65536           35.71µ ± 0%   32.29µ ± 0%  -9.57% (p=0.002 n=6)
    ChaCha20/1000x65         44.63µ ± 0%   41.05µ ± 0%  -8.02% (p=0.002 n=6)
    geomean                  2.235µ        2.073µ       -7.26%
    
                     | chacha20.prev.out |          chacha20.new.out         |
                     |       B/s         |     B/s       vs base             |
    ChaCha20/64             355.1Mi ± 0%   389.8Mi ± 1%   +9.78% (p=0.002 n=6)
    ChaCha20/256            1.440Gi ± 0%   1.565Gi ± 0%   +8.62% (p=0.002 n=6)
    ChaCha20/10x25          471.3Mi ± 0%   472.8Mi ± 2%   +0.31% (p=0.589 n=6)
    ChaCha20/4096           1.684Gi ± 0%   1.859Gi ± 0%  +10.38% (p=0.002 n=6)
    ChaCha20/100x40         711.8Mi ± 3%   760.3Mi ± 2%   +6.80% (p=0.002 n=6)
    ChaCha20/65536          1.709Gi ± 0%   1.890Gi ± 0%  +10.59% (p=0.002 n=6)
    ChaCha20/1000x65        1.356Gi ± 0%   1.475Gi ± 0%   +8.72% (p=0.002 n=6)
    geomean                 957.3Mi        1.008Gi        +7.83%
    Change-Id: Ib31cb10a2a11eacdacf0272fbfd887eb5ccd8bcb
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564797
    Reviewed-by: Lynn Boger <[email protected]>
    Run-TryBot: Paul Murphy <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Run-TryBot: Lynn Boger <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    jkrishmys authored and laboger committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8d0d405 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. ssh: add server side multi-step authentication

    Add support for sending back partial success to the client while
    handling authentication in the server. This is implemented by a special
    error that can be returned by any of the authentication methods, which
    contains the authentication methods to offer next.
    
    This patch is based on CL 399075 with some minor changes and the
    addition of test cases.
    
    Fixes golang/go#17889
    Fixes golang/go#61447
    Fixes golang/go#64974
    
    Co-authored-by: Peter Verraedt <[email protected]>
    Change-Id: I05c8f913bb407d22c2e41c4cbe965e36ab4739b0
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/516355
    Reviewed-by: Andrew Lytvynov <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Filippo Valsorda <[email protected]>
    Auto-Submit: Filippo Valsorda <[email protected]>
    2 people authored and gopherbot committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6f79b5a View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. ssh: respect MaxAuthTries also for "none" auth attempts

    Only the first "none" auth attempt is allowed without penality
    
    Change-Id: Ibe776e968ba406445eeb94e8f1959383b88c98f7
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/575995
    Reviewed-by: Filippo Valsorda <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Nicola Murino <[email protected]>
    Commit-Queue: Nicola Murino <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    drakkan authored and gopherbot committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b92bf94 View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ib20227810c7e72942dd6fc33731fc613784aedec
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/576515
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d042a39 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. sha3: fix Sum results for SHAKE functions on s390x

    Sum was taking the digest from the state which is correct for SHA-3
    functions but not for SHAKE functions.
    
    Updates golang/go#66804
    
    Change-Id: If782464d773262075950e3168128c0d46e4a6530
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/578715
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Filippo Valsorda <[email protected]>
    Run-TryBot: Michael Munday <[email protected]>
    mundaym committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5defcc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. openpgp: fix function name in comment

    Change-Id: Ic788ebe311fafa0f5d9750d5f7f25fb70dc0606d
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/579175
    Run-TryBot: shuang cui <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    cuishuang authored and gopherbot committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0da2a6a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. ssh: validate key type in SSH_MSG_USERAUTH_PK_OK response

    According to RFC 4252 Section 7 the algorithm in SSH_MSG_USERAUTH_PK_OK
    should match that of the request but some servers send the key type instead.
    OpenSSH checks for the key type, so we do the same.
    
    Fixes golang/go#66438
    Fixes golang/go#64785
    Fixes golang/go#56342
    Fixes golang/go#54027
    
    Change-Id: I2f733f0faece097e44ba7a97c868d30a53e21d79
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/573360
    Auto-Submit: Nicola Murino <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Run-TryBot: Nicola Murino <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    Reviewed-by: Filippo Valsorda <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Joedian Reid <[email protected]>
    drakkan authored and rolandshoemaker committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ebb717d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I19d5fc3e26b53fba06b4fbcf3817c44477265210
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/583355
    Auto-Submit: Gopher Robot <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    gopherbot committed May 6, 2024
    Configuration menu
    Copy the full SHA
    905d78a View commit details
    Browse the repository at this point in the history
Loading