-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: Check replacements in config vs replace in go.mod for transitive dependency changes #8072
Comments
I have all my redirects in the root module, even those for those requires in mod1 and mod2. Not sure if I misunderstand the issue at hand, but this way it works for me on updates further down the labyrinth. And then, in my release scripts I run a recursive update in all modules on whatever level. Before I had redirects per module requirement and often the updates did not come through. It gets messy if more modules receive updates in one go. The release script does:
|
is this the same issue? same setup:
When module.replacements is set in project for mod1 to a local directory, |
perhaps I'm misreading the documentation ( https://github.com/golang/go/wiki/Modules#gomod ) or this issue, but I think 'replace' only applies to the top level module, and so that is consistent with the tests I was running in my setup ( project => compound theme (locally) => custom theme modifications (locally). I had to use |
Currently, if you have:
And add
replacements
directive in yourconfig.toml
formod1
(to edit it manually). If you then updates the Git ref frommod1 => mod2
to a different version, that version does not get picked up -- the replacements directive is for that module only and not its imports.You will get the truth when running
go mod graph
, but this is different from doing the same with areplace
directive ingo.mod
.When you really think about it this may not be that surprising, and I'm not sure we can do more than to document it better -- but we need to think.
The text was updated successfully, but these errors were encountered: