PostCSS on Windows does not work in directories with spaces

[Heasummn]

I'm still having this issue as of 5/28/2020. I've narrowed down the issue to here:

hugo/resources/resource_transformers/postcss/postcss.go

Line 192 in 6add6d7

cmdArgs = []string{"--config", configFile}

Specifically, Go's exec.Command will treat spaces in parameters as different parameters, so they must be escaped or quoted if they have spaces.

I do not have the capabilities (right now) to get Hugo building on my machine, but I believe the simplest fix will be somehow escaping the string when passing it to exec.Command.

I believe, but cannot be certain, that this line should fix this issue:

configFile = `"` + configFile + `"`

This was closed as stale in #6283, but I think my solution should fix the problem.

[exprez135]

Perhaps it would be better to use the Quote() function in strconv, e.g.

configFile = strconv.Quote(configFile)

Though I'm not sure:

1. If configFile will ever already be defined with quotes,

2. If Quote() already checks if it's quoted (I don't think it does).

I could test some changes if someone has an example repository that uses PostCSS.

[Heasummn]

I don't have a minimal failing example, but anything using the PostCSS hook that is built into Hugo should trigger this error.

{{ $css := resources.Get "css/main.css" }}
{{ $style := $css | resources.PostCSS }}

on your CSS file with PostCSS installed in a folder where postcss.config.js has a space in the path will not work.

[jmooring]

Was postcss-cli installed globally (npm -g) or locally within the project directory?

[jannepeltola]

I can confirm this is still an issue. I have tried with both npm -g postcss-cli and a local installation.

[moorereason]

Please share your hugo version output.

[jannepeltola]

Apologies for not doing that right away - here you go:

Hugo Static Site Generator v0.80.0/extended windows/amd64 BuildDate: unknown

It is the current version available on Chocolatey.

[jannepeltola]

If it's helpful, I can spend some time tomorrow to create a minimal repro? Unfortunately I probably won't have time to do it today.

[moorereason]

A minimal demo repo is always helpful.

[jannepeltola]

So here's a repro.

With https://github.com/jannepeltola/hugo_issue_7333/, here's what happens:

C:\Users\Janne Peltola\Documents\GitHub\hugo_issue_7333>hugo env
Hugo Static Site Generator v0.80.0/extended windows/amd64 BuildDate: unknown
GOOS="windows"
GOARCH="amd64"
GOVERSION="go1.15.1"

C:\Users\Janne Peltola\Documents\GitHub\hugo_issue_7333>hugo server
Start building sites …
WARN 2021/01/14 15:54:56 found no layout file for "HTML" for kind "taxonomy": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2021/01/14 15:54:56 found no layout file for "HTML" for kind "taxonomy": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
Built in 24 ms
Error: Error building site: POSTCSS: failed to transform "css/main.css" (text/css): 'C:\Users\Janne' is not recognized as an internal or external command,
operable program or batch file.

[moorereason]

The underlying issue is that we're executing postcss.cmd. The cmd.exe command (which runs .bat and .cmd files) processes arguments differently than the rest of Windows. The os/exec package doesn't escape commands properly for cmd.exe usage.

Related upstream issues: golang/go#15566 golang/go#17149

[jannepeltola]

I see. Thanks for looking into this! I'll run Hugo inside Docker for the time being then until when (if...) the upstream issue gets resolved.

[Heasummn]

It's a frustrating workaround, but it looks like adding quotes to the exec command should solve this issue. I can set up an environment to test that change.

[jannepeltola]

I can build and test a branch locally if you need a Windows environment!