Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with overlapping file mounts #7123

Open
bep opened this issue Apr 3, 2020 · 6 comments
Open

Issue with overlapping file mounts #7123

bep opened this issue Apr 3, 2020 · 6 comments
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Apr 3, 2020

I'm not sure what, but I see some odd behaviour when using it. Need to look into it.

@bep bep added the Bug label Apr 3, 2020
@bep bep added this to the v0.68.4 milestone Apr 3, 2020
@bep bep self-assigned this Apr 3, 2020
@bep
Copy link
Member Author

bep commented Apr 3, 2020

Note that is is about multiple, e.g. layouts mount in the same module -- not multiple modules (which I use all the time).

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Aug 8, 2020
@bep bep added the Keep label Aug 10, 2020
@stale stale bot removed the Stale label Aug 10, 2020
@shauntarves
Copy link

I can vouch for having this issue, especially with a multi-lingual site. When making multiple mounts from, say, the local (project) module, the behavior of the union file system is non-deterministic - e.g., sometimes I get files from the first mount, sometimes I get files from the second mount, etc.

This is especially relevant in a multi-lingual site where the content directories are mounted from the local project space, and there is module path overlap.

I'm happy to provide further specifics of what I see if it's helpful, but sounds like it's already a known issue

@moorereason
Copy link
Contributor

@shauntarves,
If you can put together a small demo site that reproduces the issue, it would be helpful.

@shauntarves
Copy link

shauntarves commented Feb 1, 2021

Hi @moorereason ,

Maybe I am just generally having issues understanding how the union virtual filesystem works. If I have the following content directory:

support/
  index.md
  images/
    banana.png

And then I import a module which attempts to override the banana.png with its own version, does that work? I've tried all kinds of import mount configurations, but it just doesn't seem to take. For example:

[[module.imports]]
  path = "github.com/starves/efe"
  disable = false
[[module.imports.mounts]]
  source = "content/support/images"
  target = "content/support/images"
[[module.imports.mounts]]
  source = "content/support/images/banana.png"
  target = "content/support/images/banana.png"
[[module.imports.mounts]]
  source = "content/support"
  target = "content/support"

Any thoughts?

@shauntarves
Copy link

@bep Any chance you can help on this?

@bep bep modified the milestones: v0.69, v0.83 Apr 23, 2021
@bep bep modified the milestones: v0.83, v0.84 May 3, 2021
@bep bep modified the milestones: v0.84, v0.85 Jun 18, 2021
@bep bep modified the milestones: v0.85, v0.86 Jul 5, 2021
@bep bep modified the milestones: v0.86, v0.87 Jul 26, 2021
@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
@bep bep modified the milestones: v0.125.0, v0.126.0 Apr 23, 2024
@bep bep modified the milestones: v0.126.0, v0.127.0 May 15, 2024
@bep bep modified the milestones: v0.127.0, v0.128.0 Jun 8, 2024
@bep bep modified the milestones: v0.128.0, v0.129.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants