Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return any value in errorf #6653

Closed
bep opened this issue Dec 20, 2019 · 4 comments
Closed

Do not return any value in errorf #6653

bep opened this issue Dec 20, 2019 · 4 comments
Assignees
@bep
Labels
Outdated
Milestone
v0.62

Comments

@bep
Copy link
Member

bep commented Dec 20, 2019

Related to #6652, but lest take it in a separate issue.

This would probably make sense before we got the server error page, but now it's just annoying, esp. for people who want to publish even if there are ERRORs.
@bep bep added this to the v0.62 milestone Dec 20, 2019
@bep bep self-assigned this Dec 20, 2019
@bep bep closed this as completed in 50cc7fe Dec 21, 2019
@moorereason
Copy link
Contributor

What about people who expect the build to fail on errorf?

@bep
Copy link
Member Author

bep commented Dec 21, 2019

What about them?

@moorereason
Copy link
Contributor

Ignore me. I misunderstood what you were talking about here. 🤦‍♂

@jaaufauvre jaaufauvre mentioned this issue Sep 24, 2021
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Outdated
Projects
None yet
Milestone
v0.62
Development

No branches or pull requests
2 participants
@moorereason @bep