-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of local anchor links in the built in link render hook #12503
Comments
With the current implementation, if a summary rendered on a list page contains a same-page link, the link will properly resolve to the containing page instead of doing nothing. |
Yea, right, I didn't think about that ... I'll put it on my list to check for "browser behaviour". Anyhow, people are free to add their own template. |
While monitoring the Network tab of Chrome's dev tools, I see no difference between There may be some other side effect that I'm not aware of, but this approach seems to be fine. |
I think we can close this issue per my previous comment. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In my head this
hugo/tpl/tplimpl/embedded/templates/_default/_markup/render-link.html
Line 4 in 3d40aba
Should only include the anchor part (e.g.
#foo
) and not the.RelPermalink
to the current page. I'm not totally sure how the different browsers handle this, but I'm pretty sure there's a difference.I noticed this surface on the forum, see https://discourse.gohugo.io/t/markdown-syntax-render/49835
/cc @jmooring
The text was updated successfully, but these errors were encountered: