Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified enable sourceMap field name #10605

Closed
septs opened this issue Jan 7, 2023 · 3 comments
Closed

Unified enable sourceMap field name #10605

septs opened this issue Jan 7, 2023 · 3 comments

Comments

@septs
Copy link
Contributor

septs commented Jan 7, 2023

enableSourceMap [bool]
: When enabled, a source map will be generated.

noMap [bool]
: Default is `false`. Disable the default inline sourcemaps

sourceMap
: Whether to generate `inline` or `external` sourcemap from esbuild. External sourcemaps will be written to the target with the output filename + ".map". Input sourcemaps can be read from js.Build and node modules and combined into the output sourcemaps.

sourceMap [string]
: Output `inline` or `external` sourcemap from the babel compile. External sourcemaps will be written to the target with the output filename + ".map". Input sourcemaps can be read from js.Build and node modules and combined into the output sourcemaps.

Unified sourceMap field name, i think can simplify expected

@septs
Copy link
Contributor Author

septs commented Jan 11, 2023

expect unified as

sourceMap: [
  "inline",   (enable inline source map, if availabe)
  "external", (enable external source map, if availabe)
  "",         (disable source map)
  true,       (enable source map, if availabe)
  false,      (disable source map)
]

@bep bep added this to the v0.109.0 milestone Jan 17, 2023
@bep
Copy link
Member

bep commented Jan 17, 2023

Yea, I agree, but we obviously need to respect the old prop key(s).

@bep bep modified the milestones: v0.109.0, v0.111.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@bep bep modified the milestones: v0.112.0, v0.113.0 Apr 15, 2023
@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 5, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
@septs septs closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants