Fix Spinbox display does not round properly when using decimal custom arrow steps

[shahriarlabib000]

Fixes #97561

[shahriarlabib000]

I think it's fixed now?

[KoBeWi]

Why this? rounded should always make the value rounded.

[shahriarlabib000]

Oh sorry, now that you mention it, I think it should be removed too. It's been awhile but I think the reasoning was the value was not updating if the arrow_step was too low. But I guess that logic is flawed. I'll remove it

[shahriarlabib000]

Oh ok, so if i set the step to 0.8 the value cannot get beyond 2.
Maybe the rounding logic is flawed somehow? Or is that not how I'm supposed to use it?

[KoBeWi]

It's a pre-existing bug, so it can be fixed later.
Not sure what's the expected behavior here, maybe rounded could force the arrow step to be at least 1.
Then again, when both steps are 0, the arrows don't work either.

[shahriarlabib000]

I don't like how it partially duplicates set_value(), but if it works better then ok.

Maybe we could give set value () an optional custom_step parameter or maybe that's a bad idea

[shahriarlabib000]

What about the exp_edit ?

[KoBeWi]

exp_edit is irrelevant for SpinBox.

[shahriarlabib000]

Is it possible to hide it from the inspector somehow?

[KoBeWi]

Yes, by using _validate_property().

[shahriarlabib000]

Okay maybe for another pr if I can figure out how to use it 😅

[KoBeWi]

Works fine now.
You could maybe add some comments for the new code, on why is it like that.

[shahriarlabib000]

@KoBeWi
So if the step is 0, and the value is being typed, it seems that the displayed value's precision is affected.
What if we do something like this?
shahriarlabib000/godot@spinBox...shahriarlabib000:godot:spinThyBox

void SpinBox::_update_text(bool p_keep_line_edit) {
	String value = String::num(get_value(), Math::range_step_decimals(get_step()));
	double value_for_calculating_precision = get_value();
	int decimal = 0;
	while((int)value_for_calculating_precision != value_for_calculating_precision) {
		value_for_calculating_precision *= 10;
		++decimal;
		if(decimal >= 10) {
			break;
		}
	}

	String value = String::num(get_value(), decimal);

[KoBeWi]

I think that's a separate issue.

[Repiteo]

Thanks!