Update Inspector when renaming a file via File System Dock

[pafuent]

Fixes #56803

Adding a new signal file_renamed to FileSystemDock and then connecting it to InspectorDock to update the path of the file on object_selector.

2024-09-23.00-55-14.mov

[pafuent]

Updated to the latest master version.
Can I get a review?

[KoBeWi]

Does not work when you rename a script.

[pafuent]

Seems it's worst than not updating a script. When I implemented this fix I test it with an empty project (as it can be viewed on the video attached on the description) and it worked for the Godot icon (my bad that doesn't work with scripts 🤦🏼‍♂️ )
Now, I tested it within a project with a scene and a node, and after renaming the Godot icon, the first (or last selected) node of the scene is shown in the inspector node, instead of the Godot icon. That behavior is already present on 4.3, so it seems is an existing bug.
I'll try to come with a solution for both things as soon as I can.

Here is a GIF with the bug on 4.3

[Mickeon]

To me it looks like the new signal added in this PR is emitted every time a single file's path changes, so file_renamed and its purpose would be misleading.

But why adding a new signal when files_moved already exists?

[pafuent]

To me it looks like the new signal added in this PR is emitted every time a single file's path changes, so file_renamed and its purpose would be misleading.
But why adding a new signal when files_moved already exists?

I decided to add a new signal because a moved file doesn't imply the name of the file changed, and the inspector requires being updated only when the name of the file changed.
TBH, I think that I need to revisit the whole implementation that I did. After some PRs I know some things that I didn't know at that time.

[Mickeon]

The signal being called file_moved is admittedly a bit misleading, but it is a general Filesystem standard to call it as such (Git also considers "renamed" files as "moved"). Ideally it should be documented to be clearer.
Adding file_renamed would also imply that file_moved is not called when renaming, which is misleading too.