Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Better error logging #330

Open
smimani-godaddy opened this issue Oct 29, 2020 · 0 comments
Open

[Go] Better error logging #330

smimani-godaddy opened this issue Oct 29, 2020 · 0 comments

Comments

@smimani-godaddy
Copy link
Contributor

Describe the bug
If DynamoDB contains SKs encrypted using Static KMS, switching to AWS KMS causes a panic with a weird error message, if the SK is still active. The error message could/should be more descriptive so that the cause of the failure becomes evident. Right now it logs something like:

panic: unable to unmarshal envelope: invalid character '%' looking for beginning of value
goroutine 1 [running]:
main.main()
        /Users/smimani/GoDaddy/AppEncryption/asherah/samples/go/referenceapp/main.go:199 +0x81a
exit status 2

To Reproduce
Steps to reproduce the behavior:

  1. Run go-reference app with Static KMS and DynamoDB metastore and all other default values
  2. Run go-reference app with AWS KMS and DynamoDB metastore and all other default values
  3. See error

Expected behavior
A more descriptive error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant