Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: fix nginx ingress auth-signin example #11096

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

diegmonti
Copy link
Contributor

Details

Update nginx ingress documentation per #6886 (comment)


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@diegmonti diegmonti requested a review from a team as a code owner August 28, 2024 12:39
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 2fcade9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66cf1a9b0f4fd70008feac35

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 2fcade9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66cf1a9bc6431800081d758a
😎 Deploy Preview https://deploy-preview-11096--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (cdbf448) to head (2fcade9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11096      +/-   ##
==========================================
+ Coverage   92.68%   92.76%   +0.07%     
==========================================
  Files         736      736              
  Lines       36426    36426              
==========================================
+ Hits        33763    33792      +29     
+ Misses       2663     2634      -29     
Flag Coverage Δ
e2e 49.27% <ø> (+0.10%) ⬆️
integration 25.01% <ø> (ø)
unit 90.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

Thanks so much for this fix, @diegmonti !

@tanberry tanberry merged commit 17fb90e into goauthentik:main Aug 28, 2024
68 checks passed
@diegmonti diegmonti deleted the fix/docs-auth-signin branch August 28, 2024 14:50
kensternberg-authentik added a commit that referenced this pull request Aug 29, 2024
* main:
  websites/docs: minor tweaks to rel notes (#11123)
  website/docs: fix outdated docs and typos (#11020)
  web: fix e2e tests to work with latest WebdriverIO and authentik 2024.8 (#11105)
  website/integrations: Fix Nextcloud SAML Docs for SLO (#11118)
  core: bump twisted from 24.3.0 to 24.7.0 (#11119)
  ci: fix failing release attestation (#11107)
  core: bump importlib-metadata from 8.0.0 to 8.4.0 (#11112)
  core: bump google-api-python-client from 2.142.0 to 2.143.0 (#11113)
  core: bump selenium from 4.23.1 to 4.24.0 (#11114)
  web: bump the swc group across 2 directories with 11 updates (#11115)
  enterprise: fix incorrect comparison for latest validity date (#11109)
  website/docs: 2024.8 release notes: reword group sync disable and fix… (#11103)
  website/docs: add info about external users (#11106)
  website/docs: a couple of minor rewrite things (#11099)
  web: bump @sentry/browser from 8.26.0 to 8.27.0 in /web in the sentry group across 1 directory (#11093)
  website: bump webpack from 5.89.0 to 5.94.0 in /website (#11098)
  website/docs: fix nginx ingress auth-signin example (#11096)
  core: bump github.com/jellydator/ttlcache/v3 from 3.2.1 to 3.3.0 (#11091)
  core: bump pdoc from 14.6.0 to 14.6.1 (#11092)
  web: bump @patternfly/elements from 4.0.0 to 4.0.1 in /web (#11094)
kensternberg-authentik added a commit that referenced this pull request Aug 30, 2024
* main:
  website/docs: fix outdated docs and typos (#11020)
  web: fix e2e tests to work with latest WebdriverIO and authentik 2024.8 (#11105)
  website/integrations: Fix Nextcloud SAML Docs for SLO (#11118)
  core: bump twisted from 24.3.0 to 24.7.0 (#11119)
  ci: fix failing release attestation (#11107)
  core: bump importlib-metadata from 8.0.0 to 8.4.0 (#11112)
  core: bump google-api-python-client from 2.142.0 to 2.143.0 (#11113)
  core: bump selenium from 4.23.1 to 4.24.0 (#11114)
  web: bump the swc group across 2 directories with 11 updates (#11115)
  enterprise: fix incorrect comparison for latest validity date (#11109)
  website/docs: 2024.8 release notes: reword group sync disable and fix… (#11103)
  website/docs: add info about external users (#11106)
  website/docs: a couple of minor rewrite things (#11099)
  web: bump @sentry/browser from 8.26.0 to 8.27.0 in /web in the sentry group across 1 directory (#11093)
  website: bump webpack from 5.89.0 to 5.94.0 in /website (#11098)
  website/docs: fix nginx ingress auth-signin example (#11096)
  core: bump github.com/jellydator/ttlcache/v3 from 3.2.1 to 3.3.0 (#11091)
  core: bump pdoc from 14.6.0 to 14.6.1 (#11092)
  web: bump @patternfly/elements from 4.0.0 to 4.0.1 in /web (#11094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants