Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Hello - Mismatch between ECCParameters in pubArea and credentialPublicKey #222

Closed
glacuesta-sa opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
status/in-review In Review type/question Further information is requested

Comments

@glacuesta-sa
Copy link

Version

0.9.4

Description

Attestation bug with Direct & TPM on Windows Hello (Windows 11 22H2).
Searching found it was reported in another library too:
MasterKale/SimpleWebAuthn#238

Reproduction

Trying to enroll Windows 11 22H2 Hello authenticator with
Attestation=Direct
AuthenticatorType=Platform(TPM)

It ends in "Mismatch between ECCParameters in pubArea and credentialPublicKey" error but it should work.

Expectations

Should enroll the device successfully.

Documentation

No response

@glacuesta-sa glacuesta-sa added status/needs-triage Issues that need to be triaged. type/potential-bug Potential Bugs labels Feb 22, 2024
@aseigler aseigler self-assigned this Feb 22, 2024
@aseigler
Copy link
Collaborator

I could have sworn this got fixed (by me) in the summer/fall of 2022. Are you saying you can reproduce this today on current codebase with W11 22H2? Or is this 23H2? Can you post a winver like this
image

@glacuesta-sa
Copy link
Author

glacuesta-sa commented Feb 22, 2024

Yes it can still be reproduced on Windows 11 22H2, I will get a screenshot of that as soon as possible. I'm using 0.9.4 of the library, should I upgrade to at least 0.10.x? It works just fine for Windows 11 23H2 as far as I tested.

@glacuesta-sa
Copy link
Author

@aseigler I'm sorry, I noticed this particular one has been using an older version. In which version was it fixed? Probably doesn't have the fix you're talking about.

@aseigler
Copy link
Collaborator

aseigler commented Feb 22, 2024

Whew, you had me there for a second.

Pretty sure this got fixed in #43, library version 0.4.0 or later, which is when the test for this particular case got added.

@glacuesta-sa
Copy link
Author

glacuesta-sa commented Feb 22, 2024

In this particular one was using github.com/duo-labs/webauthn v0.0.0-20220122034320-81aea484c951

At that moment I was using duo-labs still, so probably doesn't have all these fixes mentioned above. I think is fine to close this as is a false positive.

So we can close this issue, as there is no issue :)

@aseigler
Copy link
Collaborator

Sounds good to me! Thanks for the followup!

@james-d-elliott james-d-elliott added type/question Further information is requested status/in-review In Review and removed type/potential-bug Potential Bugs status/needs-triage Issues that need to be triaged. labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/in-review In Review type/question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants