Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat attestation type attca as a full attestation like basic_full #153

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Treat attestation type attca as a full attestation like basic_full #153

merged 1 commit into from
Jul 16, 2023

Conversation

aseigler
Copy link
Collaborator

@aseigler aseigler commented Jul 16, 2023 •
edited
Loading

  • For purposes of determining if an authenticator has produced a full attestation when the MDS entry for the authenticator indicates cannot produce a full attestation, treat attca and basic_full both as full attestation types
  • Add test data with an authenticator aaguid that only has attca type
  • Make production metadata available for use in tests

Resolves #149

@aseigler aseigler requested a review from a team as a code owner July 16, 2023 19:32
james-d-elliott
james-d-elliott approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit 44d68a6 into go-webauthn:master Jul 16, 2023
4 checks passed
@aseigler aseigler deleted the fix-attca branch July 17, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-elliott james-d-elliott james-d-elliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attestation with full attestation from authenticator that does not support full attestation
2 participants
@aseigler @james-d-elliott