Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api design issue #145

Closed
CoreFloDev opened this issue May 31, 2023 · 1 comment
Closed

Api design issue #145

CoreFloDev opened this issue May 31, 2023 · 1 comment
Labels
status/invalid This doesn't seem right

Comments

@CoreFloDev
Copy link
Contributor

Version

0.8.2

Description

Hi,

I don't understand why the user is required to BeginLogin and BeginRegistration to me in that situation, we don't have enough elements to know who the user is

Reproduction

Look at BeginLogin and BeginRegistration functions

Expectations

I would expect to be able to use BeginLogin and BeginRegistration without having to provide a user as what matters in that case is the challenge and RPID/RPOrigins for the credendial manager to be able to create the correct key.

Maybe it makes sense for registration as the user can provide personal information like email at this point of time. But for login, it forces the user to enter his email while he could only press a button and being logged in right away

Documentation

No response
@CoreFloDev CoreFloDev added status/needs-triage Issues that need to be triaged. type/potential-bug Potential Bugs labels May 31, 2023
@james-d-elliott james-d-elliott added status/invalid This doesn't seem right and removed type/potential-bug Potential Bugs status/needs-triage Issues that need to be triaged. labels Jun 1, 2023
@james-d-elliott
Copy link
Member

james-d-elliott commented Jun 1, 2023 •
edited

The BeginDiscoverableLogin func can be used for discoverable logins. If this doesn't meet your needs please provide some documentation in a feature request as this is not a bug.

@james-d-elliott james-d-elliott closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CoreFloDev @james-d-elliott